✨ New MucSpinner Component

[matthilo96]

Description

Add new component. Text has a maximum of 80 characters. Lines are broken after 14 characters. Text is centered vertically and horizontally. Screen readers do not read the text aloud. This is not currently necessary. Perhaps there will be a ticket for this in the future.

Reference

Issues #608

[FabianWilms]

The differences between the percentage spinner and this variant is pretty minor. I would prefer to have one muc-spinner component which can be switched to display either text or a percentage. Maybe have two properties

• percentage
• text

and only one of which can be used at the same time.

This will make maintaining this component way easier.

Can you merge your code and the current muc-percentage-spinner together to one muc-spinner component?

[matthilo96]

Yes, I can merge them.
What should the component be called then?
All projects that already use muc-percentage-spinner would have to rename it in their project if it has a different name after the release, right?
So should the component continue to be called muc-percentage-spinner even though text can now also be displayed?

[FabianWilms]

I think muc-spinner is a valid name. And yes, this will be a breaking change but that's ok. When you use the 💥 Gitmoji this will trigger a new major release and mark this change as a breaking change.

If you want to make the change graceful you would have to make src/components/PercentageSpinner/index.ts point to your new component so existing imports will still work. If that is a hurdle you want to take go for it :D