-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Fixes type name for tendon properties in from_files config
#3941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tendon imports in from_files_cfg had a typo that prevented importing. This is resolved in this commit. Signed-off-by: Kyle Morgenstein <34984693+KyleM73@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Greptile Summary
Fixed type annotation typos in FileCfg class for tendon properties. The types FixedTendonsPropertiesCfg and SpatialTendonsPropertiesCfg incorrectly had plural "Tendons" instead of singular "Tendon", preventing these configurations from being imported and used properly.
Key changes:
- Line 42:
FixedTendonsPropertiesCfg→FixedTendonPropertiesCfg - Line 45:
SpatialTendonsPropertiesCfg→SpatialTendonPropertiesCfg
These type annotations now correctly match the actual class names defined in schemas_cfg.py, allowing users to properly configure tendon properties when spawning articulated assets from URDF or USD files.
Confidence Score: 5/5
- This PR is completely safe to merge with zero risk
- The fix corrects a simple typo in type annotations that prevented valid imports. The changes are minimal (only 2 lines), the correct type names were verified against the actual class definitions in schemas_cfg.py, and no similar typos exist elsewhere in the codebase. This is a straightforward bug fix with no logic changes.
- No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| source/isaaclab/isaaclab/sim/spawners/from_files/from_files_cfg.py | 5/5 | Fixed typos in tendon property type annotations: FixedTendonsPropertiesCfg → FixedTendonPropertiesCfg and SpatialTendonsPropertiesCfg → SpatialTendonPropertiesCfg |
Sequence Diagram
sequenceDiagram
participant User
participant FileCfg
participant from_files
participant schemas
participant USD_Prim
User->>FileCfg: Create config with tendon properties
Note over FileCfg: fixed_tendons_props: FixedTendonPropertiesCfg
Note over FileCfg: spatial_tendons_props: SpatialTendonPropertiesCfg
User->>from_files: spawn_from_usd(prim_path, cfg)
alt cfg.fixed_tendons_props is not None
from_files->>schemas: modify_fixed_tendon_properties(prim_path, cfg.fixed_tendons_props)
schemas->>USD_Prim: Apply fixed tendon properties
end
alt cfg.spatial_tendons_props is not None
from_files->>schemas: modify_spatial_tendon_properties(prim_path, cfg.spatial_tendons_props)
schemas->>USD_Prim: Apply spatial tendon properties
end
from_files-->>User: Return spawned prim
1 file reviewed, no comments
ooctipus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Mayankm96
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this!
from_files config
Tendon imports in from_files_cfg had a typo that prevented importing. This is resolved in this commit. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [X] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [X] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [X] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [X] I have added my name to the `CONTRIBUTORS.md` or my name already exists there Signed-off-by: Kyle Morgenstein <34984693+KyleM73@users.noreply.github.com>
Tendon imports in from_files_cfg had a typo that prevented importing. This is resolved in this commit.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there