Skip to content

Conversation

@KyleM73
Copy link
Contributor

@KyleM73 KyleM73 commented Nov 4, 2025

Tendon imports in from_files_cfg had a typo that prevented importing. This is resolved in this commit.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Tendon imports in from_files_cfg had a typo that prevented importing. This is resolved in this commit.

Signed-off-by: Kyle Morgenstein <34984693+KyleM73@users.noreply.github.com>
@github-actions github-actions bot added bug Something isn't working isaac-lab Related to Isaac Lab team labels Nov 4, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

Fixed type annotation typos in FileCfg class for tendon properties. The types FixedTendonsPropertiesCfg and SpatialTendonsPropertiesCfg incorrectly had plural "Tendons" instead of singular "Tendon", preventing these configurations from being imported and used properly.

Key changes:

  • Line 42: FixedTendonsPropertiesCfgFixedTendonPropertiesCfg
  • Line 45: SpatialTendonsPropertiesCfgSpatialTendonPropertiesCfg

These type annotations now correctly match the actual class names defined in schemas_cfg.py, allowing users to properly configure tendon properties when spawning articulated assets from URDF or USD files.

Confidence Score: 5/5

  • This PR is completely safe to merge with zero risk
  • The fix corrects a simple typo in type annotations that prevented valid imports. The changes are minimal (only 2 lines), the correct type names were verified against the actual class definitions in schemas_cfg.py, and no similar typos exist elsewhere in the codebase. This is a straightforward bug fix with no logic changes.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
source/isaaclab/isaaclab/sim/spawners/from_files/from_files_cfg.py 5/5 Fixed typos in tendon property type annotations: FixedTendonsPropertiesCfgFixedTendonPropertiesCfg and SpatialTendonsPropertiesCfgSpatialTendonPropertiesCfg

Sequence Diagram

sequenceDiagram
    participant User
    participant FileCfg
    participant from_files
    participant schemas
    participant USD_Prim
    
    User->>FileCfg: Create config with tendon properties
    Note over FileCfg: fixed_tendons_props: FixedTendonPropertiesCfg
    Note over FileCfg: spatial_tendons_props: SpatialTendonPropertiesCfg
    
    User->>from_files: spawn_from_usd(prim_path, cfg)
    
    alt cfg.fixed_tendons_props is not None
        from_files->>schemas: modify_fixed_tendon_properties(prim_path, cfg.fixed_tendons_props)
        schemas->>USD_Prim: Apply fixed tendon properties
    end
    
    alt cfg.spatial_tendons_props is not None
        from_files->>schemas: modify_spatial_tendon_properties(prim_path, cfg.spatial_tendons_props)
        schemas->>USD_Prim: Apply spatial tendon properties
    end
    
    from_files-->>User: Return spawned prim
Loading

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Collaborator

@ooctipus ooctipus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Mayankm96 Mayankm96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@Mayankm96 Mayankm96 moved this to In review in Isaac Lab Nov 20, 2025
@Mayankm96 Mayankm96 changed the title [Bug Fix] Fix type name for tendon properties in from_files config Fixes type name for tendon properties in from_files config Nov 20, 2025
@Mayankm96 Mayankm96 merged commit e9e33b2 into isaac-sim:main Nov 20, 2025
6 of 8 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Isaac Lab Nov 20, 2025
kellyguo11 pushed a commit that referenced this pull request Nov 26, 2025
Tendon imports in from_files_cfg had a typo that prevented importing.
This is resolved in this commit.

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## Checklist

- [X] I have read and understood the [contribution
guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html)
- [X] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [ ] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [X] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

Signed-off-by: Kyle Morgenstein <34984693+KyleM73@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working isaac-lab Related to Isaac Lab team

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants