Pass through HTTPX Client config #265
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
What’s the rationale here? Why do you need it? |
Member
|
Sorry, just read #264! |
results in mypy error (although this seems like a mistake, it would just overwrite the default timeout value if it was provided).
Kilo59
force-pushed
the
f/http_client_config
branch
from
599911b to
c4d8107
Compare
Kilo59
force-pushed
the
f/http_client_config
branch
from
c4d8107 to
55db020
Compare
Author
|
@JonasKs I'm happy to add additional docs here if needed. |
Kilo59
force-pushed
the
f/http_client_config
branch
from
5deb2d2 to
e13f8d8
Compare
Kilo59
force-pushed
the
f/http_client_config
branch
from
e13f8d8 to
8422ef9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for configuration of the HTTPX Clients.
This is especially needed when users want to set a custom SSL context.