Skip to content

Conversation

@lukaszstolarczuk
Copy link
Contributor

It's better to use the actually last nightly build in benchmarks.

@lukaszstolarczuk lukaszstolarczuk requested a review from a team November 7, 2025 18:03
@lukaszstolarczuk lukaszstolarczuk requested a review from a team as a code owner November 7, 2025 18:03
schedule:
# 3 hours ahead of SYCL nightly
- cron: '0 0 * * *'
# 2 hours after SYCL nightly
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyone remember if this was on purpose, to run before the SYCL nightly workflow, not after?

A few days back we hit an issue, which was fixed by updating dockers... and they were not used in benchmarks' workflow, as it used the old nightly docker....

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea if was on purpose but imo the new behavior is correct, any benchmarks of the nightly should be benchmarking that nightly

@aelovikov-intel
Copy link
Contributor

Can you use a trigger like this

on:
workflow_run:
workflows: [SYCL Pre Commit on Linux]
types:
- completed

instead of relying on the scheduling delay?

@sarnex
Copy link
Contributor

sarnex commented Nov 7, 2025

Can you use a trigger like this instead of relying on the scheduling delay?

While maybe less clean I think the scheduling delay is safer, in theory there could be a race condition if the images are a little slow to be available for download after being uploaded, a 3 hour delay should prevent that

@aelovikov-intel
Copy link
Contributor

Can you use a trigger like this instead of relying on the scheduling delay?

While maybe less clean I think the scheduling delay is safer, in theory there could be a race condition if the images are a little slow to be available for download after being uploaded, a 3 hour delay should prevent that

I'm relying on it being available here

image: ghcr.io/${{ github.repository }}/sycl_prebuilt_tests:${{ inputs.ref || github.ref_name }}

but that only runs manually and very rarely. Haven't had issues, but maybe I was just lucky. Google search's AI says

In the context of GitHub Actions workflows, one job can immediately use the image pushed by a previous job, provided the correct permissions and naming conventions are used.

but I didn't verify that's not a hallucination.

To sum up, @lukaszstolarczuk , your call. Both Nick and I are fine with either approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants