-
Notifications
You must be signed in to change notification settings - Fork 795
[CI][Bench] Run nightly benchmarks after the nightly image was pushed #20598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
[CI][Bench] Run nightly benchmarks after the nightly image was pushed #20598
Conversation
| schedule: | ||
| # 3 hours ahead of SYCL nightly | ||
| - cron: '0 0 * * *' | ||
| # 2 hours after SYCL nightly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyone remember if this was on purpose, to run before the SYCL nightly workflow, not after?
A few days back we hit an issue, which was fixed by updating dockers... and they were not used in benchmarks' workflow, as it used the old nightly docker....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no idea if was on purpose but imo the new behavior is correct, any benchmarks of the nightly should be benchmarking that nightly
|
Can you use a trigger like this llvm/.github/workflows/sycl-linux-precommit-aws.yml Lines 13 to 17 in 7aa73a8
instead of relying on the scheduling delay? |
While maybe less clean I think the scheduling delay is safer, in theory there could be a race condition if the images are a little slow to be available for download after being uploaded, a 3 hour delay should prevent that |
I'm relying on it being available here
but that only runs manually and very rarely. Haven't had issues, but maybe I was just lucky. Google search's AI says
but I didn't verify that's not a hallucination. To sum up, @lukaszstolarczuk , your call. Both Nick and I are fine with either approach. |
It's better to use the actually last nightly build in benchmarks.