Skip to content

[SYCL] Clear usesAssert required by fallback assert #20571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: sycl
Choose a base branch
from
+0 −17
Draft

[SYCL] Clear usesAssert required by fallback assert #20571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08c561e
[SYCL] Clear usesAssert required by fallback assert
jinge90 Nov 6, 2025
984c1e9
Merge remote-tracking branch 'upstream/sycl' into remove_usesAssert_u…
jinge90 Nov 6, 2025
3a6dfc5
Merge remote-tracking branch 'upstream/sycl' into remove_usesAssert_u…
jinge90 Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions sycl/source/detail/queue_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,13 +435,6 @@ EventImplPtr queue_impl::submit_kernel_scheduler_bypass(
}

bool DiscardEvent = !EventNeeded && supportsDiscardingPiEvents();
if (DiscardEvent) {
// Kernel only uses assert if it's non interop one
bool KernelUsesAssert =
!(KernelImplPtr && KernelImplPtr->isInterop()) && KData.usesAssert();
DiscardEvent = !KernelUsesAssert;
}

std::shared_ptr<detail::event_impl> ResultEvent =
DiscardEvent ? nullptr : detail::event_impl::create_device_event(*this);

Expand Down
10 changes: 0 additions & 10 deletions sycl/source/detail/scheduler/commands.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3346,16 +3346,6 @@ ur_result_t ExecCGCommand::enqueueImpQueue() {
const std::shared_ptr<detail::kernel_impl> &SyclKernel =
ExecKernel->MSyclKernel;
KernelNameStrRefT KernelName = ExecKernel->MDeviceKernelInfo.Name;

if (!EventImpl) {
// Kernel only uses assert if it's non interop one
bool KernelUsesAssert = (!SyclKernel || SyclKernel->hasSYCLMetadata()) &&
ExecKernel->MDeviceKernelInfo.usesAssert();
if (KernelUsesAssert) {
EventImpl = MEvent.get();
}
}

const RTDeviceBinaryImage *BinImage = nullptr;
if (detail::SYCLConfig<detail::SYCL_JIT_AMDGCN_PTX_KERNELS>::get()) {
BinImage = retrieveKernelBinary(*MQueue, KernelName);
Expand Down
Loading