Merge OpenAI Triton commit 318fa9c
#5498
Merged
+1,044
−181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just to keep the branches in sync
…ions (#8605) Currently `async_wait` in Gluon on `CDNA4` requires the kernel writer to pass the number of outstanding hardware instructions/llvm intrinsic to `async_wait`. This count is very difficult to compute as it relies on layouts, sizes, contiguity... This PR changes the semantics of `async_wait` to represent the number of outstanding commit groups. This follows the semantics used for nvidia in Gluon. Therefore, Gluon kernels need to commit outstanding async operations via `commit_group` and then wait on them via `wait_group`. I also adapted the names so existing Gluon kernels using the old semantics error out. `UpdateAsyncWaitCount` is extended to compute the number of outstanding hardware instructions based on the number of oustanding commits groups. Previously, it only worked on `async_waits` carrying tokens of the commit groups which are not available when compiling a Gluon kernel. This is done by walking the IR backwards following *all* possible control flow paths and finding the smallest number of emitted instructions for N outstanding commit groups.
On GFX9, this PR lifts computations of `wave_id` to the entry of the function and additionally emit `lvm.amdgcn.readfirstlane`. This gives us optimized code generation inside the loop.
This PR introduces a common interface for buffer ops. --------- Co-authored-by: Alexander Efimov <efimov.alexander@gmail.com>
API doesn't accept scale for the intermediate tensor produced between split_k and fused_scatter; this mode should therefore be disabled for now. Will be re-enabled after expert aggregation is moved out of the matmul_ogs API
chengjunlu
approved these changes
Nov 18, 2025
Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
whitneywhtsang
force-pushed
the
whitneywhtsang/merge
branch
from
dc24a14 to
ea925e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Triton base from b3cf593 to 318fa9c (Nov 2).
Pass rate: 94.95%->98.1%