Skip to content

Conversation

@dee-kryvenko
Copy link
Contributor

Resolves #2557


Before the change?

Added a new max_per_page configuration option to the provider block backed by GITHUB_MAX_PER_PAGE env variable as default fn.

After the change?

Current behavior remains backward compatible as the default is still set to 100.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@dee-kryvenko
Copy link
Contributor Author

I wanted to add it as a param to Config struct but the whole shenanigans with Config not being available in the runtime context and instead having the Meta() as interface{} and the casting - I am baffled what is going on in there, and didn't want to touch any of that. This should be safe enough since TF guarantees ConfigureContextFunc to be called thread safely.

Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@nickfloyd nickfloyd merged commit 59fd2b7 into integrations:main Nov 12, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in Terraform Provider Nov 12, 2025
@github-project-automation github-project-automation bot moved this from 🆕 Triage to ✅ Done in 🧰 Octokit Active Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

[BUG]: github_organization_team_sync_groups causing unhandled 429 (Too Many Attempts) errors

2 participants