Optimization render of cluster markers #352
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hz61p1
force-pushed
the
optimization-of-cluster-markers
branch
from
3e68f37 to
f0b6989
Compare
Collaborator
|
Thanks for the PR @hz61p1 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error is caused by the fact that every time a marker is added or removed, the cluster render is triggered, which negatively impacts performance and may even freeze the browser tab.
This adds debounce for rendering markers in the cluster, which fixes performance issues. It may close issue #305. I'm not sure what the timeout for debounce should be, but with the current value, I haven't noticed any issues. Just in case, I added a prop for configuration.