refactor(modules/alb): remove unnecessary configuration

BREAKING CHANGE: This commit removes support for certain configuration.

Author: saumitra-dev

modules/alb/README.md

@@ -31,7 +31,7 @@ No modules.
 |------|-------------|------|---------|:--------:|
 | <a name="input_enable_deletion_protection"></a> [enable\_deletion\_protection](#input\_enable\_deletion\_protection) | (Optional) If true, deletion of the load balancer will be disabled via the AWS API. | `bool` | `false` | no |
 | <a name="input_internal"></a> [internal](#input\_internal) | (Optional) If true, the LB will be internal. | `bool` | `false` | no |
-| <a name="input_listeners"></a> [listeners](#input\_listeners) | Listeners to forward ALB ingress to desired Target Groups. | <pre>map(object({<br>    default_action = list(object({<br>      type           = string<br>      target_group   = string<br>      fixed_response = optional(any, null)<br>      forward        = optional(any, null)<br>      order          = optional(number)<br>      redirect       = optional(any, null)<br>    }))<br>    alpn_policy     = optional(string)<br>    certificate_arn = optional(string)<br>    port            = optional(number)<br>    protocol        = optional(string)<br>    ssl_policy      = optional(string)<br>    tags            = optional(map(string), {})<br>  }))</pre> | n/a | yes |
+| <a name="input_listeners"></a> [listeners](#input\_listeners) | Listeners to forward ALB ingress to desired Target Groups. | <pre>map(object({<br>    default_action = list(object({<br>      type           = string<br>      target_group   = string<br>      fixed_response = optional(any, null)<br>      forward        = optional(any, null)<br>      order          = optional(number)<br>      redirect       = optional(any, null)<br>    }))<br>    certificate_arn = optional(string)<br>    port            = optional(number)<br>    protocol        = optional(string)<br>    ssl_policy      = optional(string)<br>    tags            = optional(map(string), {})<br>  }))</pre> | n/a | yes |
 | <a name="input_name"></a> [name](#input\_name) | (Optional) Name of the LB. | `string` | `""` | no |
 | <a name="input_preserve_host_header"></a> [preserve\_host\_header](#input\_preserve\_host\_header) | (Optional) Whether the Application Load Balancer should preserve the Host header in the HTTP request and send it to the target without any change. | `bool` | `false` | no |
 | <a name="input_security_groups_ids"></a> [security\_groups\_ids](#input\_security\_groups\_ids) | (Optional) List of security group IDs to assign to the LB. | `list(string)` | `[]` | no |

modules/alb/main.tf

@@ -1,10 +1,14 @@
+locals {
+  load_balancer_type = "application"
+}
+
 ################################################################################
 # Load Balancer
 ################################################################################
 
 resource "aws_lb" "this" {
   name               = var.name
-  load_balancer_type = "application"
+  load_balancer_type = local.load_balancer_type
   internal           = var.internal
 
   subnets         = var.subnets_ids
@@ -58,7 +62,6 @@ resource "aws_lb_listener" "this" {
 
   load_balancer_arn = aws_lb.this.arn
 
-  alpn_policy     = each.value.alpn_policy
   certificate_arn = each.value.certificate_arn
   port            = each.value.port
   protocol        = each.value.protocol

modules/alb/variables.tf

@@ -76,7 +76,6 @@ variable "listeners" {
       order          = optional(number)
       redirect       = optional(any, null)
     }))
-    alpn_policy     = optional(string)
     certificate_arn = optional(string)
     port            = optional(number)
     protocol        = optional(string)

tests/alb_unit_tests.tftest.hcl

@@ -212,7 +212,6 @@ run "lb_listener_attributes_match" {
 
     listeners = {
       this = {
-        alpn_policy     = "HTTP2Preferred"
         certificate_arn = "arn:aws:acm:us-west-2:123456789012:certificate/12345678-1234-1234-1234-123456789012"
         port            = 1234
         protocol        = "HTTPS"
@@ -232,11 +231,6 @@ run "lb_listener_attributes_match" {
     }
   }
 
-  assert {
-    condition     = aws_lb_listener.this["this"].alpn_policy == var.listeners["this"].alpn_policy
-    error_message = "ALPN policy mismatch"
-  }
-
   assert {
     condition     = aws_lb_listener.this["this"].certificate_arn == var.listeners["this"].certificate_arn
     error_message = "Certificate ARN mismatch"