refactor(modules/acm): remove unnecessary configuration

BREAKING CHANGE: This commit removes support for certain configuration.

Author: saumitra-dev

modules/acm/README.md

@@ -28,7 +28,7 @@ No modules.
 
 | Name | Description | Type | Default | Required |
 |------|-------------|------|---------|:--------:|
-| <a name="input_amazon_issued_certificates"></a> [amazon\_issued\_certificates](#input\_amazon\_issued\_certificates) | List of Amazon-issued certificates to ACM create. | <pre>map(object({<br>    domain_name               = string<br>    subject_alternative_names = optional(list(string), [])<br>    validation_method         = optional(string, null)<br>    key_algorithm             = optional(string, null)<br>    options = optional(object({<br>      certificate_transparency_logging_preference = optional(string, null)<br>    }))<br>    validation_option = optional(object({<br>      domain_name       = string<br>      validation_domain = string<br>    }))<br>    tags = optional(map(string), {})<br>  }))</pre> | `{}` | no |
+| <a name="input_amazon_issued_certificates"></a> [amazon\_issued\_certificates](#input\_amazon\_issued\_certificates) | List of Amazon-issued certificates to ACM create. | <pre>map(object({<br>    domain_name               = string<br>    subject_alternative_names = optional(list(string), [])<br>    validation_method         = optional(string, null)<br>    key_algorithm             = optional(string, null)<br>    validation_option = optional(object({<br>      domain_name       = string<br>      validation_domain = string<br>    }))<br>    tags = optional(map(string), {})<br>  }))</pre> | `{}` | no |
 | <a name="input_imported_certificates"></a> [imported\_certificates](#input\_imported\_certificates) | List of imported certificates to use to create ACM certificates. | <pre>map(object({<br>    private_key       = string<br>    certificate_body  = string<br>    certificate_chain = optional(string, null)<br>    tags              = optional(map(string), {})<br>  }))</pre> | `{}` | no |
 | <a name="input_tags"></a> [tags](#input\_tags) | (Optional) Map of tags to assign to the resource. | `map(string)` | `{}` | no |
 

modules/acm/main.tf

@@ -10,14 +10,6 @@ resource "aws_acm_certificate" "amazon_issued" {
   validation_method         = each.value.validation_method
   key_algorithm             = each.value.key_algorithm
 
-  dynamic "options" {
-    for_each = try(each.value.options, null) != null ? [1] : []
-
-    content {
-      certificate_transparency_logging_preference = each.value.options.certificate_transparency_logging_preference
-    }
-  }
-
   dynamic "validation_option" {
     for_each = try(each.value.validation_option, null) != null ? [1] : []
 

modules/acm/variables.tf

@@ -9,9 +9,6 @@ variable "amazon_issued_certificates" {
     subject_alternative_names = optional(list(string), [])
     validation_method         = optional(string, null)
     key_algorithm             = optional(string, null)
-    options = optional(object({
-      certificate_transparency_logging_preference = optional(string, null)
-    }))
     validation_option = optional(object({
       domain_name       = string
       validation_domain = string

tests/acm_unit_tests.tftest.hcl

@@ -21,10 +21,6 @@ run "amazon_issued_certificates_attributes_match" {
         validation_method         = "EMAIL"
         key_algorithm             = "RSA_4096"
 
-        options = {
-          certificate_transparency_logging_preference = "ENABLED"
-        }
-
         validation_option = {
           domain_name       = "example.domain"
           validation_domain = "me@example.domain"
@@ -52,11 +48,6 @@ run "amazon_issued_certificates_attributes_match" {
     error_message = "Key algorithm mismatch"
   }
 
-  assert {
-    condition     = aws_acm_certificate.amazon_issued["example"].options[0].certificate_transparency_logging_preference == var.amazon_issued_certificates.example.options.certificate_transparency_logging_preference
-    error_message = "Certificate transparency logging preference mismatch"
-  }
-
   assert {
     condition     = tolist(aws_acm_certificate.amazon_issued["example"].validation_option)[0].domain_name == var.amazon_issued_certificates.example.validation_option.domain_name
     error_message = "Validation option domain name mismatch"