-
Notifications
You must be signed in to change notification settings - Fork 187
[TASK] Hide honeypot field from screenreaders #478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The configured value `new-powermail-hp` for the autocomplete attribute is invalid and fails in the accessibility check provided by accessibilityinsights.io Valid values for autofill: https://www.w3.org/TR/html52/sec-forms.html#autofilling-form-controls-the-autocomplete-attribute
|
See #102 for the reason of the current value. |
|
The problem is, that the current value is invalid and resulting in an error in WCAG tests. TYPO3 core ext:form has those settings (see https://forge.typo3.org/projects/typo3cms-core/repository/revisions/090a852fd0d8b5e1b6062614a4197dbcb6d06a92/diff), which I believe may not resolve the problem Chrome browser has with I'd rather prefer adding a valid value to the Any opinions against such a solution? |
Added additional attributes to honeypot textfield, so it will be ignored by screenreaders.
|
I adapted the PR, so the autocomplete field can still contain an invalid value, but screenreaders will ignore the honeypot field (added Note, that I also added the form uid to be included in the autocomplete value, since this may reduce the amount of spam (see https://forge.typo3.org/issues/89420) |
|
The prefix "new-" must be still at the beginning. Could you change it to |
Done |
|
@nebrot Hello, why is the So bot maybe also fill out the valid autocomplete field. https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete |
It's semantic autocomplete to avoid autofilling e.g. in Chrome for Android. See #102 for details and https://stackoverflow.com/a/30873633 |
|
There are other solutions that pass the validator: See https://www.w3.org/TR/html52/sec-forms.html#autofilling-form-controls-the-autocomplete-attribute |
|
Also created a PR to be able to define autocomplete attributes via field properties #620 |
|
@derhansen Does this problem still exist? Can you create an issue for it? (Since this has been around a while and is not merged yet, but one cannot find this when searching in the issues tab). See also my issue, related to honey pot failing, but probably not directly related #824. |
|
Thx for raising this issue again. I just merged it to develop branch. |
The configured value
new-powermail-hpfor the autocomplete attribute is invalid and fails in the accessibility check provided by accessibilityinsights.ioAFAIK, valid values for autofill are: