Skip to content

Conversation

@Lawproto
Copy link
Member

The hand had some changes in the last year that were not tracked at coupling law level and its parameter. Time to create a new Mk5.2 from the current as-is hand. This PR updates all the related documentation.

@Lawproto Lawproto requested a review from pattacini as a code owner November 25, 2025 16:46
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Lawproto, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request formally documents the newly established Mk5.2 version of the robotic hand. It addresses previously untracked changes in the hand's physical parameters and coupling laws by introducing new, detailed sections for joint specifications and coupling variables. The goal is to ensure that the project's documentation accurately reflects the current 'as-is' state of the Mk5.2 hardware, providing essential reference information for future development and understanding.

Highlights

  • New Mk5.2 Hand Documentation: Introduced comprehensive documentation for the new Mk5.2 hand version, detailing its joint specifications and coupling variables.
  • Updated Joint Specifications: Added a new section in hands_mk5.md with a detailed table outlining the joint numbers, motors, identifiers, types, parent/child links, and hardware limits for all fingers of the Mk5.2 hand.
  • Revised Coupling Variables and Parameters: Created a dedicated section in hands_mk5_coupling.md for Mk5.2, providing an extensive table of coupling variables and parameters, including new q1rest and q2rest values.
  • Clarified Parameter Definitions: Included detailed notes in the Mk5.2 coupling variables section to explain the shift in hard stop for the rest position and a generalized definition for q2bias, accompanied by illustrative images.
  • Minor Documentation Refinements: Renamed P1x and P1y parameters to P1x(0) and P1y(0) in the Mk5.1 and Mk5.0 coupling variables tables for consistency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Lawproto Lawproto self-assigned this Nov 25, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces documentation for the new Mk5.2 hand, including joint specifications and coupling variables. The changes are a good step towards tracking the new hardware version. I've identified a few minor issues, such as typos and opportunities for clarification, which will improve the quality and readability of the documentation. My feedback focuses on removing editing artifacts, clarifying notes, and suggesting additions for completeness.

Lawproto and others added 4 commits November 25, 2025 17:57
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@pattacini pattacini merged commit 0c58886 into icub-tech-iit:master Nov 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants