Skip to content

IBX-10933: Fix tooltip display by adding data-tooltip-container for popup #1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 4.6
Choose a base branch
from
Open

IBX-10933: Fix tooltip display by adding data-tooltip-container for popup #1781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/bundle/ui-dev/src/modules/common/popup/popup.component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,8 @@
data-bs-dismiss="modal"
aria-label={closeBtnLabel}
onClick={hidePopup}
title={closeBtnLabel}
data-tooltip-container-selector={'.c-popup'}
>
<Icon name="discard" extraClasses="ibexa-icon--small" />
</button>
Expand Down Expand Up @@ -138,7 +140,10 @@
: title && (
<>
<div className="modal-header c-popup__header">
<h3 className="modal-title c-popup__headline" title={showTooltip ? title : null}>
<h3
className="modal-title c-popup__headline"
{...(showTooltip ? { title, 'data-tooltip-container-selector': '.c-popup' } : {})}

Check warning on line 145 in src/bundle/ui-dev/src/modules/common/popup/popup.component.js

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 


See more on https://sonarcloud.io/project/issues?id=ibexa_admin-ui&issues=AZq7drs1GoChscpFNu8n&open=AZq7drs1GoChscpFNu8n&pullRequest=1781
>
<span className="c-popup__title">{title}</span>
{subtitle && <span className="c-popup__subtitle">{subtitle}</span>}
</h3>
Expand Down
Loading