IBX-10609: Enhance notification deletion by integrating modal confirmation. #1736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RopRaptor
commented
Oct 13, 2025
| const confirmDeleteButton = doc.querySelector('.ibexa-notifications-modal--delete--confirm'); | ||
| const setNotificationId = ({ currentTarget }) => { | ||
| const deleteModal = doc.querySelector('.modal-backdrop.show.fade'); | ||
| controlZIndex(deleteModal, '199'); |
Contributor
Author
There was a problem hiding this comment.
Not very satisfied with this solution.
I had to move the modal-backdrop back in the z-index because it was covering the entire container.
Opened for suggestions
|
RopRaptor
requested review from
GrabowskiM,
OstafinL,
albozek,
dew326 and
tischsoic
tischsoic
approved these changes
Oct 31, 2025
Comment on lines
+249
to
+250
| const deleteButtons = doc.querySelectorAll('.ibexa-notifications-open-modal-button'); | ||
| const confirmDeleteButton = doc.querySelector('.ibexa-notifications-modal--delete--confirm'); |
Contributor
There was a problem hiding this comment.
nitpick - naming convention
Suggested change
| const deleteButtons = doc.querySelectorAll('.ibexa-notifications-open-modal-button'); | |
| const confirmDeleteButton = doc.querySelector('.ibexa-notifications-modal--delete--confirm'); | |
| const deleteBtns = doc.querySelectorAll('.ibexa-notifications-open-modal-button'); | |
| const confirmDeleteBtn = doc.querySelector('.ibexa-notifications-modal--delete--confirm'); |
dew326
approved these changes
Nov 13, 2025
KamilSznajdrowicz
force-pushed
the
IBX-10609-delete-modal-in-notification
branch
from
71ed035 to
1165501
Compare
|
KamilSznajdrowicz
requested changes
Nov 26, 2025
Contributor
KamilSznajdrowicz
left a comment
KamilSznajdrowicz
left a comment
There was a problem hiding this comment.
Hi @RopRaptor :) I found two bugs here:
- When the modal appears, the popup with notifications should also be dimmed. Currently, it is not dimmed.
- After clicking the Delete button, the actions dropdown should close. Currently, it stays visible on the screen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Documentation: