-
Notifications
You must be signed in to change notification settings - Fork 326
fix: add json compatibility for infrastructure tab #1256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 8a1f61e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Someone is attempting to deploy a commit to the HyperDX Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| }, | ||
| ); | ||
|
|
||
| // Normalize resource and event attributes to always use flat keys for both JSON and Map columns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix makes sense to me. We normalize the attributes structure upstream so that the downstream chart component can render properly.
wrn14897
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good. We just need to fix the linting error @hiasr
|
Can't run CI, but all linting errors related to the files I changed look fixed locally. |
wrn14897
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Hi! This PR fixes two things to improve the infrastructure context panel.
Feel free to make suggestions about a different approach, I wasn't sure about the current idiomatic way to handle the JSON<>Map distinction.