Support additional upstream proxy connection formats #186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request addresses request #184 that I raised to supporting additional proxy formats. I tested my changes using my own proxy. The cases I tested are:
hosthost:portuser:pass@host:portuser@host:portuser:pass@hostuser@hosthost:port:user:passhost:port@user:passusers:pass:host:portuser_12345,type_residential,session_123:pass:host.dev.com:1234(complex valid)user:pass:host:1080:extra(invalid)user:pass:https://proxy.host.com:1234(invalid)Proxies in the format of 7-9 get saved to the
rulesStoreas format 3.EDIT: Ran into some rebasing issues in my previous CR #185 and had to create a new pull request 😅