-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Quoc/convert-to-general-documents2 #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
qpham01
wants to merge
38
commits into
https-deeplearning-ai:main
Choose a base branch
from
qpham01:quoc/convert-to-general-documents2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Quoc/convert-to-general-documents2 #36
qpham01
wants to merge
38
commits into
https-deeplearning-ai:main
from
qpham01:quoc/convert-to-general-documents2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added reminders to always use uv for running server and managing dependencies instead of pip. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This reverts commit 6270b0a.
This reverts commit a745f05.
- Fix MAX_RESULTS=0 in config.py causing ChromaDB search failures - Add defensive fallback in vector_store.py for zero search limits - Add comprehensive test suite with 59 tests across 4 test files - Tests cover CourseSearchTool, AI generator, RAG system, and vector store - Add pytest dependencies for testing infrastructure 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove single tool usage limitation from system prompt - Add multi-round tool usage capability (max 2 rounds) - Support complex queries requiring multiple searches/comparisons - Preserve conversation context between rounds - Add graceful error handling for tool execution failures - Include comprehensive test suite for sequential behavior - Maintain backward compatibility with existing single-round usage 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sequential tool calling
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add theme toggle button with sun/moon icons in header top-right - Implement comprehensive light theme with proper contrast ratios - Add smooth 0.3s CSS transitions for seamless theme switching - Include localStorage persistence for user theme preferences - Provide full keyboard accessibility and ARIA label support - Maintain existing design language and visual hierarchy 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add pytest configuration with test markers and asyncio support - Create comprehensive API endpoint test suite (15 test cases) - Tests for /api/query, /api/courses, /api/session/new, and / endpoints - Error handling validation for all endpoints - Source format compatibility (dict vs string sources) - Request/response model validation - Enhance conftest.py with mock RAG system and test app fixtures - Add httpx dependency for HTTP testing capabilities - Isolate test environment by defining API endpoints inline to avoid static file mounting issues All new API tests pass, providing robust testing infrastructure for FastAPI endpoints. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add black, isort, and flake8 for Python code formatting and linting - Create PowerShell scripts for code quality management (format.ps1, quality-check.ps1, check-quality.ps1) - Format entire codebase with black and isort for consistent style - Update CLAUDE.md with code quality commands and dependencies - Add code quality tool permissions to Claude Code settings - Maintain all existing functionality while improving code consistency 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Resolved conflicts in: - backend/tests/conftest.py: Combined imports and fixtures from both branches - pyproject.toml: Merged dependencies and testing configuration - uv.lock: Regenerated lock file with combined dependencies 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Successfully merged all work trees from .trees folder: - quality_feature: Added comprehensive code quality tooling and formatting - testing_feature: Enhanced RAG testing framework with comprehensive API endpoint tests - ui_feature: Added dark/light theme toggle with smooth transitions All conflicts resolved and dependencies synchronized. Includes updated Claude Code settings for additional command permissions. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…83408 Add Claude Code GitHub Workflow
…tle and subtitle - Remove ''Course Materials Assistant'' header and subtitle text - Remove horizontal border below header - Keep theme toggle button positioned to the right - Update page title to ''RAG Chatbot'' Fixes #3 Co-authored-by: Quoc Pham <qpham01@users.noreply.github.com>
Revert header to older version - remove Course Materials Assistant ti…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.