Skip to content

Remove emitter closure from LndmobileCallback instances #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
esen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove emitter closure from LndmobileCallback instances #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions LightningKit/Local/LndMobileCallbacks/MessageResponseCallback.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,27 +3,30 @@ import Lndmobile
import SwiftProtobuf

class MessageResponseCallback<T:Message>: NSObject, LndmobileCallbackProtocol {
private let emitter: (SingleEvent<T>) -> Void
private var emitter: ((SingleEvent<T>) -> Void)?

init(emitter: @escaping (SingleEvent<T>) -> Void) {
self.emitter = emitter
}

func onError(_ error: Error?) {
emitter(.error(error ?? LndMobileCallbackError.unknownError))
emitter?(.error(error ?? LndMobileCallbackError.unknownError))
}

func onResponse(_ response: Data?) {
guard let responseData = response else {
emitter(.success(T()))
emitter?(.success(T()))
emitter = nil
return
}

guard let responseMessage = try? T(serializedData: responseData) else {
emitter(.error(LndMobileCallbackError.responseCannotBeDecoded))
emitter?(.error(LndMobileCallbackError.responseCannotBeDecoded))
emitter = nil
return
}

emitter(.success(responseMessage))
emitter?(.success(responseMessage))
emitter = nil
}
}
4 changes: 3 additions & 1 deletion LightningKit/Local/LndMobileCallbacks/VoidResponseCallback.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,19 @@ import RxSwift
import Lndmobile

class VoidResponseCallback: NSObject, LndmobileCallbackProtocol {
private let emitter: ((SingleEvent<Void>) -> Void)?
private var emitter: ((SingleEvent<Void>) -> Void)?

init(emitter: ((SingleEvent<Void>) -> Void)?) {
self.emitter = emitter
}

func onError(_ error: Error?) {
emitter?(.error(error ?? LndMobileCallbackError.unknownError))
emitter = nil
}

func onResponse(_ response: Data?) {
emitter?(.success(Void()))
emitter = nil
}
}