-
Notifications
You must be signed in to change notification settings - Fork 92
chore: auto comparison proto and source for tokens #792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: auto comparison proto and source for tokens #792
Conversation
|
@Adityarya11 and @nikhil-nari - you both requested harder issues |
|
I already love this. Such a good idea! also here - could we automate this so it's a bot being kicked off on a pipeline run (not automatically on every push ofc, but only on manual run)? and then when it finds a discrepancy, it raises an issue to add the mssing property? |
Signed-off-by: exploreriii <133720349+exploreriii@users.noreply.github.com>
Signed-off-by: exploreriii <133720349+exploreriii@users.noreply.github.com>
Signed-off-by: exploreriii <133720349+exploreriii@users.noreply.github.com>
Signed-off-by: exploreriii <133720349+exploreriii@users.noreply.github.com>
Signed-off-by: exploreriii <133720349+exploreriii@users.noreply.github.com>
Signed-off-by: exploreriii <133720349+exploreriii@users.noreply.github.com>
Signed-off-by: exploreriii <133720349+exploreriii@users.noreply.github.com>
Signed-off-by: exploreriii <133720349+exploreriii@users.noreply.github.com>
Signed-off-by: exploreriii <133720349+exploreriii@users.noreply.github.com>
Signed-off-by: exploreriii <133720349+exploreriii@users.noreply.github.com>
Signed-off-by: exploreriii <133720349+exploreriii@users.noreply.github.com>
Signed-off-by: exploreriii <133720349+exploreriii@users.noreply.github.com>
Signed-off-by: exploreriii <133720349+exploreriii@users.noreply.github.com>
ecc6700 to
defc6ef
Compare
|
@tech0priyanshu if you find any issues here (you'll need to use this as a guide and double check) 💠 CustomFee vs CustomFee
💠 NftId vs NftID
💠 PendingAirdropId vs PendingAirdropId
💠 PendingAirdropRecord vs PendingAirdropRecord
💠 TokenAirdropTransaction vs TokenAirdropTransactionBody
💠 TokenCancelAirdropTransaction vs TokenCancelAirdropTransactionBody 💠 TokenAssociateTransaction vs TokenAssociateTransactionBody
💠 TokenBurnTransaction vs TokenBurnTransactionBody 💠 TokenCreateTransaction vs TokenCreateTransactionBody
💠 TokenDeleteTransaction vs TokenDeleteTransactionBody 💠 TokenDissociateTransaction vs TokenDissociateTransactionBody
💠 TokenFeeScheduleUpdateTransaction vs TokenFeeScheduleUpdateTransactionBody 💠 TokenFreezeTransaction vs TokenFreezeAccountTransactionBody 💠 TokenGrantKycTransaction vs TokenGrantKycTransactionBody 💠 TokenId vs TokenID
💠 TokenInfo vs TokenInfo
💠 TokenMintTransaction vs TokenMintTransactionBody 💠 TokenNftInfo vs TokenNftInfo
💠 TokenPauseTransaction vs TokenPauseTransactionBody 💠 TokenRelationship vs TokenRelationship
💠 TokenRevokeKycTransaction vs TokenRevokeKycTransactionBody 💠 TokenTransfer vs TokenTransferList
💠 TokenTransferList vs TokenTransferList
💠 TokenUnfreezeTransaction vs TokenUnfreezeAccountTransactionBody 💠 TokenUpdateNftsTransaction vs TokenUpdateNftsTransactionBody 💠 TokenUpdateTransaction vs TokenUpdateTransactionBody
💠 TokenWipeTransaction vs TokenWipeAccountTransactionBody
|

Attempts automatic parsing of proto and lists possible attributes and setters, comparing it to what we have.
CURRENTLY PROOOF OF CONCEPT
Reduces time to create an issue and improves accuracy.
Fixes #
#791
Currently in draft --- am looking for feedback on output to see if we can finetune this further.
Currently working on improving the accuracy of the proto elements found and not cause duplaictes