feat: Add set node account id method #362

aceppaluni · 2025-09-08T16:27:04Z

Description:
Add Set_node_account_ids() method to Query and Transaction for retrieving receipts or records.

Added methods to both Query and Transaction
Added unit test for Query
Added unit test for Transaction

Related issue(s):

Fixes #86

Notes for reviewer:
Ran tests for both Query and Transaction

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

Signed-off-by: Angelina <aceppaluni@gmail.com>

Signed-off-by: dosi <dosi.kolev@limechain.tech>

…xamples Signed-off-by: dosi <dosi.kolev@limechain.tech>

Signed-off-by: dosi <dosi.kolev@limechain.tech>

exploreriii

Hi @accepaluni please remember to pre-fix your PR title eg
feat: add set node account id method
additionally, we now have a changelog, which must be updated with each PR

src/hiero_sdk_python/transaction/transaction.py

nadineloepfe · 2025-10-06T14:49:00Z

Hi @aceppaluni,
are you still working on this?
also, would you mind adding a "feat:" in front of your PR title as well as an entry in the CHANGELOG? thanks

aceppaluni · 2025-10-14T21:29:41Z

Hi @nadineloepfe Yes, my apologies.
I have been a bit busier then normal. Of course, will do, thank you!

…ion flow (hiero-ledger#362) Signed-off-by: Angelina <aceppaluni@gmail.com>

aceppaluni · 2025-11-17T23:26:19Z

Hi @nadineloepfe
I added the List and AccountId imports as requested. However, Codacy is reporting warnings like “Using variable 'AccountId' before assignment,” which seem to be related to the TYPE_CHECKING import. Before I change anything, I wanted to confirm whether we want to keep the AccountId import inside TYPE_CHECKING, or move it to a normal import so Codacy is satisfied?

I'm happy to apply whichever approach you prefer.
Thank you!

nadineloepfe · 2025-11-18T07:16:00Z

Hi @nadineloepfe I added the List and AccountId imports as requested. However, Codacy is reporting warnings like “Using variable 'AccountId' before assignment,” which seem to be related to the TYPE_CHECKING import. Before I change anything, I wanted to confirm whether we want to keep the AccountId import inside TYPE_CHECKING, or move it to a normal import so Codacy is satisfied?

I'm happy to apply whichever approach you prefer. Thank you!

whatever makes Codacy happy :D
normal import works! thank you

src/hiero_sdk_python/executable.py

…ion flow (hiero-ledger#362) Signed-off-by: Angelina <aceppaluni@gmail.com>

aceppaluni · 2025-11-19T17:26:48Z

Hi @nadineloepfe and @exploreriii
Codacy is producing false positives in executable.py, saying "Using variable AccountId before assignment."
The project imports AccountId normally, so this looks like a Codacy bug.
Do you want me to suppress these warnings, adjust Codacy config, or ignore them?”

exploreriii

Hi @aceppaluni
Sorry i think my message did not go through

Your account id import is pointed to the incorrect path, that's probably why its not recognised

from hiero_sdk_python.account.account_id import AccountId

…ion flow (hiero-ledger#362) Signed-off-by: Angelina <aceppaluni@gmail.com>

aceppaluni · 2025-11-19T19:09:03Z

Hi @exploreriii No problem.
Its still producing a false positive, should I suppress these warnings or ignore them?

exploreriii

The import is not quite right still, try this first and let's see if it improves:
from hiero_sdk_python.account.account_id import AccountId

the reason why this is correct is the account id class is inside the account file under src.

Signed-off-by: Angelina <aceppaluni@gmail.com>

…election Signed-off-by: Angelina <aceppaluni@gmail.com>

…ion flow (hiero-ledger#362) Signed-off-by: Angelina <aceppaluni@gmail.com>

aceppaluni · 2025-11-19T19:15:51Z

@exploreriii Hi, I think there is a bug somewhere. I keep trying to commit the new change but its not pushing for some reason. I'll have to figure out why

Signed-off-by: Angelina <aceppaluni@gmail.com>

aceppaluni · 2025-11-19T19:17:22Z

@exploreriii I think I have fixed it

nadineloepfe · 2025-11-25T02:53:14Z

src/hiero_sdk_python/query/query.py

        self.node_index: int = 0
        self.payment_amount: Optional[Hbar] = None

+        self.node_account_ids: Optional[List[AccountId]] = None


just seen - this is duplicated
there;s another self.node_account_ids on line 57. Please remove!

I've also created a branch here to see if it all works with some minor changes, see here:
https://github.com/hiero-ledger/hiero-sdk-python/pull/853/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed

mostly wanted to fix the weird error in the pipeline, hard to see what's going on

Thanks for taking the time to clean this up and address the CI issues. I’ve reviewed the changes in your branch and they all make sense. Everything looks good from my side.

Hi @aceppaluni
The tests here are still failing, what's the next steps? @nadineloepfe will you be working on the new branch any further, or will @aceppaluni use that for reference to update this PR?

Hi @exploreriii, I’m currently awaiting @nadineloepfe 's guidance on how she’d like to proceed. My understanding is that the branch she created will address the test issue and allow us to finalize this PR.

@exploreriii @aceppaluni: correct! the branch I've raised is passing, so if you'd like you can take inspiration there, and we can also jump on a call to walk through what has been done and why - bit easier than doing it here in writing :)

@nadineloepfe @exploreriii : Great! Let me know what days and times work for everyone!
I will be available at certain points today. I will not be available tomorrow. I will be available again on Friday :)

aceppaluni and others added 21 commits May 22, 2025 10:26

add tokenInfoQuery functionality

f694268

Signed-off-by: Angelina <aceppaluni@gmail.com>

refactor: update TokenInfoQuery implementation

d5310c8

Signed-off-by: dosi <dosi.kolev@limechain.tech>

test: add unit tests

76b0d85

Signed-off-by: dosi <dosi.kolev@limechain.tech>

test: add integration tests

256e807

Signed-off-by: dosi <dosi.kolev@limechain.tech>

docs: add examples for both non-fungible/fungible tokens

32443f1

Signed-off-by: dosi <dosi.kolev@limechain.tech>

docs: update README in examples

3c3a6ea

Signed-off-by: dosi <dosi.kolev@limechain.tech>

chore: add TokenInfoQuery to __init__.py

1a453ee

Signed-off-by: dosi <dosi.kolev@limechain.tech>

test: reduce test_token_info_query_execute function length

1c6ac60

Signed-off-by: dosi <dosi.kolev@limechain.tech>

test: fix incorrect integration test function names

df1069c

Signed-off-by: dosi <dosi.kolev@limechain.tech>

docs: change network from solo to testnet and some minor changes in e…

67c9eb7

…xamples Signed-off-by: dosi <dosi.kolev@limechain.tech>

test: address PR comments for integration/unit tests

d7d6c18

Signed-off-by: dosi <dosi.kolev@limechain.tech>

docs: update examples for TokenInfoQuery to address PR comments

79c1f10

Signed-off-by: dosi <dosi.kolev@limechain.tech>

Merge branch 'hiero-ledger:main' into main

a4372ad

Merge branch 'hiero-ledger:main' into main

17ace16

Merge branch 'hiero-ledger:main' into main

090b2bb

Merge branch 'hiero-ledger:main' into main

854c0ca

Merge branch 'hiero-ledger:main' into main

168d706

Merge branch 'hiero-ledger:main' into main

143b727

Merge branch 'hiero-ledger:main' into main

ad6df88

Merge branch 'hiero-ledger:main' into main

fdcc0cb

Merge branch 'hiero-ledger:main' into main

b9ad245

aceppaluni marked this pull request as ready for review September 9, 2025 14:24

exploreriii requested changes Sep 9, 2025

View reviewed changes

src/hiero_sdk_python/transaction/transaction.py Outdated Show resolved Hide resolved

src/hiero_sdk_python/transaction/transaction.py Outdated Show resolved Hide resolved

Merge branch 'hiero-ledger:main' into main

7f4ee47

Merge branch 'hiero-ledger:main' into main

e17c504

aceppaluni changed the title ~~Add set node account id method~~ feat: Add set node account id method Oct 20, 2025

aceppaluni added 2 commits October 20, 2025 18:42

Merge branch 'hiero-ledger:main' into main

22ba822

Merge branch 'hiero-ledger:main' into main

2741bde

Merge branch 'hiero-ledger:main' into main

1f4f5cf

aceppaluni added a commit to aceppaluni/hiero-sdk-python that referenced this pull request Nov 17, 2025

feat: move node account ID selection to _Executable and update execut…

0a72808

…ion flow (hiero-ledger#362) Signed-off-by: Angelina <aceppaluni@gmail.com>

aceppaluni force-pushed the AddSetNodeAccountIdMethod branch from bdcc2a4 to d47b375 Compare November 17, 2025 23:14

exploreriii requested changes Nov 19, 2025

View reviewed changes

src/hiero_sdk_python/executable.py Outdated Show resolved Hide resolved

Merge branch 'hiero-ledger:main' into main

91d86fb

aceppaluni added a commit to aceppaluni/hiero-sdk-python that referenced this pull request Nov 19, 2025

feat: move node account ID selection to _Executable and update execut…

8eb60fa

…ion flow (hiero-ledger#362) Signed-off-by: Angelina <aceppaluni@gmail.com>

aceppaluni force-pushed the AddSetNodeAccountIdMethod branch from d47b375 to d0479f0 Compare November 19, 2025 17:10

exploreriii requested changes Nov 19, 2025

View reviewed changes

Merge branch 'hiero-ledger:main' into main

fce4f9f

aceppaluni added a commit to aceppaluni/hiero-sdk-python that referenced this pull request Nov 19, 2025

feat: move node account ID selection to _Executable and update execut…

7a179bb

…ion flow (hiero-ledger#362) Signed-off-by: Angelina <aceppaluni@gmail.com>

aceppaluni force-pushed the AddSetNodeAccountIdMethod branch from d0479f0 to ea19adf Compare November 19, 2025 19:07

Merge branch 'hiero-ledger:main' into main

333f755

exploreriii requested changes Nov 19, 2025

View reviewed changes

aceppaluni added 7 commits November 19, 2025 14:13

Add set_node_account_id method

50f258e

Signed-off-by: Angelina <aceppaluni@gmail.com>

fix: add missing List import and update changelog

94c89d3

Signed-off-by: Angelina <aceppaluni@gmail.com>

style: add spacing in set_node_account_id method

e83e701

Signed-off-by: Angelina <aceppaluni@gmail.com>

feat: support selecting node account ID for execution flow

cc7d9a8

Signed-off-by: Angelina <aceppaluni@gmail.com>

Fix node selection to use _select_node instead of _get_node

dac9cd2

Signed-off-by: Angelina <aceppaluni@gmail.com>

feat: add Network._get_node() and update executable to support node s…

13a542a

…election Signed-off-by: Angelina <aceppaluni@gmail.com>

feat: move node account ID selection to _Executable and update execut…

7ffc7e4

…ion flow (hiero-ledger#362) Signed-off-by: Angelina <aceppaluni@gmail.com>

aceppaluni force-pushed the AddSetNodeAccountIdMethod branch from ea19adf to 948f76a Compare November 19, 2025 19:14

Fix imports for List and AccountId; update executable; sync with main

f521241

Signed-off-by: Angelina <aceppaluni@gmail.com>

aceppaluni force-pushed the AddSetNodeAccountIdMethod branch from 948f76a to f521241 Compare November 19, 2025 19:17

nadineloepfe reviewed Nov 25, 2025

View reviewed changes

feat: Add set node account id method #362

Are you sure you want to change the base?

feat: Add set node account id method #362

Uh oh!

Conversation

aceppaluni commented Sep 8, 2025

Uh oh!

exploreriii left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nadineloepfe commented Oct 6, 2025

Uh oh!

aceppaluni commented Oct 14, 2025

Uh oh!

aceppaluni commented Nov 17, 2025

Uh oh!

nadineloepfe commented Nov 18, 2025

Uh oh!

Uh oh!

aceppaluni commented Nov 19, 2025

Uh oh!

exploreriii left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aceppaluni commented Nov 19, 2025

Uh oh!

exploreriii left a comment

Choose a reason for hiding this comment

Uh oh!

aceppaluni commented Nov 19, 2025

Uh oh!

aceppaluni commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nadineloepfe Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aceppaluni Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

exploreriii Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

aceppaluni Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

nadineloepfe Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

aceppaluni Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

exploreriii left a comment •

edited

Loading

aceppaluni commented Nov 19, 2025 •

edited

Loading

nadineloepfe Nov 25, 2025 •

edited

Loading