-
Notifications
You must be signed in to change notification settings - Fork 90
fix: fixes failing acceptance test #4612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Test Results 4 files - 16 618 suites +346 1m 6s ⏱️ - 21m 7s Results for commit 9ba9ef2. ± Comparison against base commit c004a57. This pull request removes 791 and adds 2165 tests. Note that renamed tests count towards both.This pull request removes 4 skipped tests and adds 2 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
🚨 Memory Leak Detected 🚨A potential memory leak has been detected in the test titled Details📊 Memory Leak Detection Report 📊 GC Type: MarkSweepCompact Heap Statistics (before vs after executing the test):
Heap Space Statistics (before vs after executing the test):
RecommendationsPlease investigate the memory allocations in this test, focusing on objects that are not being properly deallocated. |
3c17da6
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
This reverts commit 3c17da6. Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
4e4da54 to
9ba9ef2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4612 +/- ##
==========================================
- Coverage 95.48% 95.47% -0.02%
==========================================
Files 129 129
Lines 20910 20903 -7
Branches 1780 1785 +5
==========================================
- Hits 19966 19957 -9
- Misses 924 926 +2
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Description
This PR fixes a failing acceptance test by adding polling for valid transaction receipt and removes @Release tag from opcode logger tests, since opcodeLogger is not enabled on MN env
Related issue(s)
Fixes #4611
Testing Guide
Changes from original design (optional)
N/A
Additional work needed (optional)
N/A
Checklist