Skip to content

Conversation

@konstantinabl
Copy link
Contributor

@konstantinabl konstantinabl commented Nov 14, 2025

Description

This PR fixes a failing acceptance test by adding polling for valid transaction receipt and removes @Release tag from opcode logger tests, since opcodeLogger is not enabled on MN env

Related issue(s)

Fixes #4611

Testing Guide

Changes from original design (optional)

N/A

Additional work needed (optional)

N/A

Checklist

  • I've assigned an assignee to this PR and related issue(s) (if applicable)
  • I've assigned a label to this PR and related issue(s) (if applicable)
  • I've assigned a milestone to this PR and related issue(s) (if applicable)
  • I've updated documentation (code comments, README, etc. if applicable)
  • I've done sufficient testing (unit, integration, etc.)

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
@konstantinabl konstantinabl requested review from a team as code owners November 14, 2025 12:01
@konstantinabl konstantinabl linked an issue Nov 14, 2025 that may be closed by this pull request
@konstantinabl konstantinabl requested a review from simzzz November 14, 2025 12:01
@konstantinabl konstantinabl self-assigned this Nov 14, 2025
@konstantinabl konstantinabl added the bug Something isn't working label Nov 14, 2025
@konstantinabl konstantinabl modified the milestone: 0.73 Nov 14, 2025
@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Test Results

    4 files   -    16    618 suites  +346   1m 6s ⏱️ - 21m 7s
2 165 tests +1 374  2 163 ✅ +1 377  2 💤  - 2  0 ❌  - 1 
2 177 runs  +1 370  2 175 ✅ +1 373  2 💤  - 2  0 ❌  - 1 

Results for commit 9ba9ef2. ± Comparison against base commit c004a57.

This pull request removes 791 and adds 2165 tests. Note that renamed tests count towards both.
"eth_call" for non-existing contract address returns 0x ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests eth_call "eth_call" for non-existing contract address returns 0x
001 Should call pureMultiply ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests eth_call Caller contract With evm address 001 Should call pureMultiply
001 Should call pureMultiply ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests eth_call Caller contract With long-zero address 001 Should call pureMultiply
002 Should call msgSender ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests eth_call Caller contract With evm address 002 Should call msgSender
002 Should call msgSender ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests eth_call Caller contract With long-zero address 002 Should call msgSender
003 Should call txOrigin ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests eth_call Caller contract With evm address 003 Should call txOrigin
003 Should call txOrigin ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests eth_call Caller contract With long-zero address 003 Should call txOrigin
004 Should call msgSig ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests eth_call Caller contract With evm address 004 Should call msgSig
004 Should call msgSig ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests eth_call Caller contract With long-zero address 004 Should call msgSig
005 Should call addressBalance ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests eth_call Caller contract With evm address 005 Should call addressBalance
…
"eth_blockNumber" return the latest block number on second try ‑ @ethGetBlockByNumber using MirrorNode "eth_blockNumber" return the latest block number on second try
"eth_blockNumber" should return the latest block number ‑ @ethGetBlockByNumber using MirrorNode "eth_blockNumber" should return the latest block number
"eth_blockNumber" should throw an error if no blocks are found after third try ‑ @ethGetBlockByNumber using MirrorNode "eth_blockNumber" should throw an error if no blocks are found after third try
"eth_blockNumber" should throw an error if no blocks are found ‑ @ethGetBlockByNumber using MirrorNode "eth_blockNumber" should throw an error if no blocks are found
Adds a revertReason field for receipts with errorMessage ‑ @ethGetTransactionReceipt eth_getTransactionReceipt tests Adds a revertReason field for receipts with errorMessage
BLOCK_HASH filter timeouts and throws the expected error ‑ @ethGetLogs using MirrorNode timeout BLOCK_HASH filter timeouts and throws the expected error
BLOCK_HASH filter ‑ @ethGetLogs using MirrorNode BLOCK_HASH filter
Can extract the account number out of an account pagination next link url ‑ MirrorNodeClient Can extract the account number out of an account pagination next link url
Can extract the evm address out of an account pagination next link url ‑ MirrorNodeClient Can extract the evm address out of an account pagination next link url
Can provide custom x-api-key header ‑ MirrorNodeClient given MIRROR_NODE_URL_HEADER_X_API_KEY=abc123iAManAPIkey are set Can provide custom x-api-key header
…
This pull request removes 4 skipped tests and adds 2 skipped tests. Note that renamed tests count towards both.
011 Should fail when calling msgValue with more value than available balance ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests eth_call Caller contract With evm address 011 Should fail when calling msgValue with more value than available balance
011 Should fail when calling msgValue with more value than available balance ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests eth_call Caller contract With long-zero address 011 Should fail when calling msgValue with more value than available balance
from/to Addresses in transaction to a contract (deployed through HAPI tx) are in evm and long-zero format ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests Formats of addresses in Transaction and Receipt results from/to Addresses in transaction to a contract (deployed through HAPI tx) are in evm and long-zero format
should not return contract bytecode after sefldestruct ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests eth_getCode should not return contract bytecode after sefldestruct
eth_gasPrice with cached value ‑ @ethGasPrice Gas Price spec @ethGasPrice eth_gasPrice with cached value
supports optionality of request id when configured ‑ RPC Server given REQUEST_ID_IS_OPTIONAL=true are set supports optionality of request id when configured

♻️ This comment has been updated with latest results.

natanasow
natanasow previously approved these changes Nov 14, 2025
simzzz
simzzz previously approved these changes Nov 14, 2025
quiet-node
quiet-node previously approved these changes Nov 14, 2025
@simzzz simzzz self-requested a review November 14, 2025 19:25
simzzz
simzzz previously approved these changes Nov 17, 2025
natanasow
natanasow previously approved these changes Nov 17, 2025
@github-actions
Copy link

🚨 Memory Leak Detected 🚨

A potential memory leak has been detected in the test titled should fail when DEBUG_API_ENABLED is false. This may impact the application's performance and stability.

Details

📊 Memory Leak Detection Report 📊

GC Type: MarkSweepCompact
Cost: 40,965.6 ms

Heap Statistics (before vs after executing the test):

  • Total Heap Size: increased with 8.65 MB
  • Total Heap Size Executable: no changes
  • Total Physical Size: increased with 524.29 KB
  • Total Available Size: increased with 87.09 KB
  • Total Global Handles Size: no changes
  • Used Global Handles Size: decreased with 32.00 bytes
  • Used Heap Size: decreased with 841.32 KB
  • Heap Size Limit: no changes
  • Malloced Memory: decreased with 165.36 KB
  • External Memory: no changes
  • Peak Malloced Memory: no changes

Heap Space Statistics (before vs after executing the test):

  • New Space:

    • Space Size: increased with 8.39 MB
    • Space Used Size: decreased with 891.56 KB
    • Space Available Size: increased with 5.02 MB
    • Physical Space Size: increased with 262.14 KB
  • Old Space:

    • Space Size: increased with 262.14 KB
    • Space Used Size: increased with 50.24 KB
    • Space Available Size: decreased with 10.52 KB
    • Physical Space Size: increased with 262.14 KB

Recommendations

Please investigate the memory allocations in this test, focusing on objects that are not being properly deallocated.

@konstantinabl konstantinabl dismissed stale reviews from natanasow, simzzz, and quiet-node via 3c17da6 November 17, 2025 14:25
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
This reverts commit 3c17da6.

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
@konstantinabl konstantinabl force-pushed the 4611-acceptance-test-failing branch from 4e4da54 to 9ba9ef2 Compare November 17, 2025 15:10
@konstantinabl konstantinabl merged commit e1a74b9 into main Nov 18, 2025
92 of 109 checks passed
@konstantinabl konstantinabl deleted the 4611-acceptance-test-failing branch November 18, 2025 12:07
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main    #4612      +/-   ##
==========================================
- Coverage   95.48%   95.47%   -0.02%     
==========================================
  Files         129      129              
  Lines       20910    20903       -7     
  Branches     1780     1785       +5     
==========================================
- Hits        19966    19957       -9     
- Misses        924      926       +2     
  Partials       20       20              
Flag Coverage Δ
config-service 98.83% <ø> (ø)
relay 90.91% <ø> (-0.01%) ⬇️
server 88.93% <ø> (ø)
ws-server 98.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Acceptance test failing

5 participants