Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -523,13 +523,13 @@ stage('Non-default environments') {
// so we skip them.
String mavenBuildAdditionalArgs = ''' \
-pl !documentation \
-pl !integrationtest/mapper/orm-spring \
-pl !integrationtest/v5migrationhelper/orm \
-pl !integrationtest/java/modules/orm-lucene \
-pl !integrationtest/java/modules/orm-elasticsearch \
-pl !integrationtest/java/modules/orm-outbox-polling-elasticsearch \
-pl !lucene-next/documentation \
-pl !lucene-next/integrationtest/java/modules/orm-lucene \
-P !springITs \
'''
String mavenDockerArgs = ""
def startedContainers = false
Expand Down Expand Up @@ -600,8 +600,7 @@ stage('Non-default environments') {
--fail-fast \
-pl ${[
'org.hibernate.search:hibernate-search-integrationtest-backend-elasticsearch'
// Add back after Spring Boot 4 update:
//, 'org.hibernate.search:hibernate-search-integrationtest-showcase-library'
, 'org.hibernate.search:hibernate-search-integrationtest-showcase-library'
].join(',')} \
-Dtest.lucene.skip=true \
-Dtest.elasticsearch.distribution=$buildEnv.distribution \
Expand Down Expand Up @@ -643,11 +642,9 @@ stage('Non-default environments') {
// Note that because we expect frequent failure and retries,
// we use --fail-fast here, to make sure we don't waste time.
retry(count: 3) {
// Add back after Spring Boot 4 update:
// ,org.hibernate.search:hibernate-search-integrationtest-showcase-library
mavenNonDefaultBuild buildEnv, """ \
--fail-fast \
-pl org.hibernate.search:hibernate-search-integrationtest-backend-elasticsearch \
-pl org.hibernate.search:hibernate-search-integrationtest-backend-elasticsearch,org.hibernate.search:hibernate-search-integrationtest-showcase-library \
-Dtest.lucene.skip=true \
-Dtest.elasticsearch.distribution=$buildEnv.distribution \
-Dtest.elasticsearch.version=$buildEnv.version \
Expand Down
9 changes: 4 additions & 5 deletions build/parents/build/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -178,11 +178,10 @@
<version.org.wildfly.security.wildfly-security-manager>1.1.2.Final</version.org.wildfly.security.wildfly-security-manager>

<!-- >>> Spring integration tests -->
<!-- When updating Spring Boot check if it supports JDK24 and enable testing with it if so (see testWithJdk24 profile). -->
<!-- When updating to SB 4 make sure to update the main Jenkinsfile to include the showcase ITs in the non-default builds -->
<version.org.springframework.boot>3.5.0</version.org.springframework.boot>
<!-- Spring Boot 3 JTA starter and related libs version: -->
<version.dev.snowdrop>3.5.0</version.dev.snowdrop>
<!-- When updating Spring Boot check if it supports JDK26 and enable testing with it if so (see testWithJdk26 profile). -->
<version.org.springframework.boot>4.0.0-RC2</version.org.springframework.boot>
<!-- Spring Boot JTA starter and related libs version: -->
<version.dev.snowdrop>4.0.0.Beta1</version.dev.snowdrop>

<version.jsoup>1.21.2</version.jsoup>
<version.snakeyaml>2.5</version.snakeyaml>
Expand Down
2 changes: 1 addition & 1 deletion build/reports/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@
<id>springITs</id>
<activation>
<!-- Hack to activate by default, except when explicitly disabled -->
<jdk>[17,25)</jdk>
<jdk>[17,)</jdk>
</activation>
<dependencies>
<dependency>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@

import org.springframework.boot.WebApplicationType;
import org.springframework.boot.autoconfigure.SpringBootApplication;
import org.springframework.boot.autoconfigure.domain.EntityScan;
import org.springframework.boot.builder.SpringApplicationBuilder;
import org.springframework.boot.persistence.autoconfigure.EntityScan;
import org.springframework.context.ConfigurableApplicationContext;

// CHECKSTYLE:OFF: HideUtilityClassConstructor
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@
import org.springframework.beans.factory.config.ConfigurableBeanFactory;
import org.springframework.boot.WebApplicationType;
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
import org.springframework.boot.autoconfigure.domain.EntityScan;
import org.springframework.boot.autoconfigure.orm.jpa.HibernatePropertiesCustomizer;
import org.springframework.boot.builder.SpringApplicationBuilder;
import org.springframework.boot.context.event.ApplicationReadyEvent;
import org.springframework.boot.hibernate.autoconfigure.HibernatePropertiesCustomizer;
import org.springframework.boot.persistence.autoconfigure.EntityScan;
import org.springframework.context.ApplicationContext;
import org.springframework.context.ConfigurableApplicationContext;
import org.springframework.context.annotation.Bean;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
import org.hibernate.search.integrationtest.spring.testsupport.AbstractSpringITConfig;

import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
import org.springframework.boot.autoconfigure.domain.EntityScan;
import org.springframework.boot.autoconfigure.transaction.jta.JtaAutoConfiguration;
import org.springframework.boot.persistence.autoconfigure.EntityScan;
import org.springframework.boot.transaction.jta.autoconfigure.JtaAutoConfiguration;
import org.springframework.context.annotation.ComponentScan;
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.Import;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import org.junit.jupiter.api.extension.RegisterExtension;

import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.autoconfigure.domain.EntityScan;
import org.springframework.boot.persistence.autoconfigure.EntityScan;
import org.springframework.context.annotation.ComponentScan;
import org.springframework.context.annotation.Configuration;
import org.springframework.stereotype.Service;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
import org.junit.jupiter.api.extension.RegisterExtension;

import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.autoconfigure.domain.EntityScan;
import org.springframework.boot.persistence.autoconfigure.EntityScan;
import org.springframework.context.annotation.ComponentScan;
import org.springframework.context.annotation.Configuration;
import org.springframework.stereotype.Service;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@

import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
import org.springframework.boot.autoconfigure.orm.jpa.HibernatePropertiesCustomizer;
import org.springframework.boot.autoconfigure.transaction.jta.JtaAutoConfiguration;
import org.springframework.boot.context.event.ApplicationReadyEvent;
import org.springframework.boot.hibernate.autoconfigure.HibernatePropertiesCustomizer;
import org.springframework.boot.transaction.jta.autoconfigure.JtaAutoConfiguration;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.context.event.EventListener;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import org.junit.jupiter.api.extension.RegisterExtension;

import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.autoconfigure.domain.EntityScan;
import org.springframework.boot.persistence.autoconfigure.EntityScan;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.context.annotation.ComponentScan;
import org.springframework.context.annotation.Configuration;
Expand Down
2 changes: 1 addition & 1 deletion integrationtest/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
<id>springITs</id>
<activation>
<!-- Hack to activate by default, except when explicitly disabled -->
<jdk>[17,25)</jdk>
<jdk>[17,)</jdk>
</activation>
<modules>
<module>mapper/orm-spring</module>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,23 +58,12 @@ public List<LibrarySimpleProjection> searchAndProject(String terms, int offset,

@Override
public List<LibrarySimpleProjection> searchAndProjectToMethodLocalClass(String terms, int offset, int limit) {
@ProjectionConstructor
class LocalClass {
public final String name;
public final List<LibraryServiceOption> services;

public LocalClass(String name, List<LibraryServiceOption> services) {
this.name = name;
this.services = services;
}
}

if ( terms == null || terms.isEmpty() ) {
return Collections.emptyList();
}
return Search.session( entityManager )
.search( Library.class )
.select( LocalClass.class )
.select( SearchAndProjectToMethodLocalClass.class )
.where( f -> f.match().field( "name" ).matching( terms ) )
.sort( f -> f.field( "collectionSize" ).desc()
.then().field( "name_sort" ) )
Expand All @@ -84,6 +73,17 @@ public LocalClass(String name, List<LibraryServiceOption> services) {
.collect( Collectors.toList() );
}

@ProjectionConstructor
static class SearchAndProjectToMethodLocalClass {
public final String name;
public final List<LibraryServiceOption> services;

public SearchAndProjectToMethodLocalClass(String name, List<LibraryServiceOption> services) {
this.name = name;
this.services = services;
}
}

@Override
public LibraryFacetedSearchResult searchFaceted(String terms, Integer minCollectionSize,
List<LibraryServiceOption> libraryServices, int offset, int limit) {
Expand Down
2 changes: 1 addition & 1 deletion lucene-next/integrationtest/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<id>springITs</id>
<activation>
<!-- Hack to activate by default, except when explicitly disabled -->
<jdk>[17,25)</jdk>
<jdk>[17,)</jdk>
</activation>
<modules>
<module>showcase/library</module>
Expand Down
12 changes: 0 additions & 12 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1348,18 +1348,6 @@
</properties>
</profile>

<profile>
<id>testWithJdk25</id>
<activation>
<!-- Hack to activate by default, except when explicitly disabled -->
<jdk>[25,)</jdk>
</activation>
<properties>
<!-- Spring Boot 3 isn't ready for JDK25 yet -->
<failsafe.spring.skip>true</failsafe.spring.skip>
</properties>
</profile>

<profile>
<id>testWithJdk26</id>
<activation>
Expand Down
Loading