-
Notifications
You must be signed in to change notification settings - Fork 105
Just for testing for now merging into develop via preview #1239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+3,356,123
β110,609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: add vault versions v1.4.x through v1.6.x to develop * fix nav data files for v1.4.x - v1.7.x * add missing partials and fix older versions * add the rest of missing partials
Updated the module test/ enable testing doc
β¦egistry/ Enable testing - doc improvment (#1197) Updated the module test/ enable testing doc Please go to the `Preview` tab and select the appropriate template: * [HCP services](?expand=1&template=hcp_pull_request_template.md) * [Terraform Enterprise](?expand=1&template=ptfe_release_pull_request_template.md) [Jira ticket](https://hashicorp.atlassian.net/browse/IPL-8749)
* Add tool files * Small updates and add headers * Fix header (again) * remove tf test data and push final tool updates
Corrects a condition where versionless documents could cause errors during partial resolution. Adds a prebuilt binary for ARM-based macOS.
Removes an unnecessary comment from the function. The comment restated the function's obvious return value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Relevant links
Preview link π
Asana task ποΈ
ποΈ What
π€· Why
The Packer documentation needed to be migrated from its standalone website to the unified documentation system to:
π οΈ How
Content Migration
Copied all relevant files from Packer repository (content, data, public, examples, etc.)
Analyzed existing product structures to understand the required layout for versionedDocs: false products
Discovered that non-versioned products require nested content/ structure: content/packer/content/docs/ instead of content/packer/docs/
Configuration Updates
Added Packer configuration to productConfig.mjs with versionedDocs: false
Enhanced the unified-docs Makefile with Packer development targets (packer-dev, packer-website-dev)
Converted Packer redirects from JavaScript to JSONC format to match unified-docs expectations
Structure Fixes
Compared with working non-versioned products (HCP docs, well-architected-framework)
Implemented nested structure (content/packer/content/docs/) and moved partials accordingly
Fixed MDX include path resolution issues by placing partials at content
Docker & Build
Resolved Docker build issues related to missing binary files in prebuild scripts
Successfully integrated Packer content processing into the unified-docs build pipeline
Verified all routes work correctly after structural changes
πΈ Design Screenshots
No design changes - this is an infrastructure/content migration maintaining existing Packer documentation appearance and functionality.
π§ͺ Testing
Verify Docker containers start successfully: docker compose --profile unified-docs up -d
Test main Packer page: http://localhost:3000/packer
Test docs landing page: http://localhost:3000/packer/docs (primary fix)
Test install page: http://localhost:3000/packer/install
Test tutorials page: http://localhost:3000/packer/tutorials
Test integrations page: http://localhost:3000/packer/integrations
Verify Makefile targets work: make packer-dev and make unified-docs
Check that redirects are properly loaded (inspect network requests)
Verify content includes/partials render correctly (no broken @include references)
π Anything else?
Future Considerations
Revert Plan
review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.