-
Notifications
You must be signed in to change notification settings - Fork 49
[WIP-00] [Project Solar / Milestone 1] Main feature branch #3237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
didoo
wants to merge
231
commits into
main
Choose a base branch
from
project-solar/phase-1-main-feature-branch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
7 tasks
519a6a6 to
3863dfa
Compare
3863dfa to
a88accd
Compare
a88accd to
5375e7a
Compare
5375e7a to
6f015ce
Compare
6f015ce to
20d4838
Compare
…t rendered as “classic” HDS
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ge for focus ring
… add `Index` (for consistency, per review comment)
…` elements when in a group
…2_showcase/carbonization-pages-scaffolding [05] [Project Solar / Phase 1 / Showcase] Scaffolding of the showcase pages for the carbonization of the HDS components
…1/00_carbon-animation-easing-format [Project Solar / Phase 1 / Engineering Follow-ups] Fix logic to extract Carbon animation easing tokens
…9/00_standardize-carbon-font-size [Project Solar / Phase 1 / Engineering Follow-ups] Normalize `font-size` units in Carbon design tokens
…tions and components (#3332)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
packages/components
packages/tokens
project solar
release-candidate
Publishes release candidates to npm
showcase
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
This is the main feature branch for the work needed to
$modes) to the CSS for the HDS components (updated to generate multiple CSS files in input, including themed tokens where needed) to the showcase (updated to support theme switching and the theming of HDS components for the their migration to the Carbon visual language, aka "carbonization")🛠️ Detailed description
This PR will include:
$modessupport for tokens/components/showcase$modessupport in tokens pipeline and component's CSS compilation #3238$modessupport to tokens pipeline #3239[04] [Project Solar / Phase 1 / Showcase] Add support for theming and theme-switching to the showcase #3240Dry-run migrations:
Follow-up activities:
$modes#3397font-sizeunits in Carbon design tokens #3400localStorageparsing validation #3401👀 Previews:
Foundations:
Components:
👷 Consumer testing PRs:
🔗 External links
Jira ticket (Milestone): https://hashicorp.atlassian.net/browse/RDPR-830
Figma file: https://www.figma.com/design/dH5BKO7rHWGZaBuK7rRt5S/Dry-runs?node-id=376-15499&p=f&t=e583xddN1Yrqpuyr-0
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.