Skip to content

Feat/create application review #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

Feat/create application review #944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
831b82c
not finished create app rev
JamieXiao Feb 22, 2025
46a2e8e
Reviewer status: 1/2 works (needs to enter twice??)
JamieXiao Mar 31, 2025
e0ee561
Hacker Reviewer Feature
JamieXiao Apr 1, 2025
6c77c84
Cleaner code
JamieXiao Apr 4, 2025
eae9218
remove uneccessary comments
JamieXiao Sep 30, 2025
f3a8957
not finished create app rev
JamieXiao Feb 22, 2025
659cd9e
Reviewer status: 1/2 works (needs to enter twice??)
JamieXiao Mar 31, 2025
61de1a3
Hacker Reviewer Feature
JamieXiao Apr 1, 2025
b9e15fb
Cleaner code
JamieXiao Apr 4, 2025
5c0b4d1
remove uneccessary comments
JamieXiao Sep 30, 2025
ec2ac9a
Merge branch 'feat/create_application_review' of https://github.com/h…
JamieXiao Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions constants/general.constant.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,24 @@ const HACKER_STATUSES = [
HACKER_STATUS_CHECKED_IN,
HACKER_STATUS_DECLINED
];

const HACKER_REVIEWER_STATUS_NONE = 'None';
const HACKER_REVIEWER_STATUS_POOR = 'Poor';
const HACKER_REVIEWER_STATUS_WEAK = 'Weak';
const HACKER_REVIEWER_STATUS_AVERAGE = 'Average';
const HACKER_REVIEWER_STATUS_STRONG = 'Strong';
const HACKER_REVIEWER_STATUS_OUTSTANDING = 'Outstanding';
const HACKER_REVIEWER_STATUS_WHITELIST = 'Whitelist';
const HACKER_REVIEWER_STATUSES = [
Copy link
Contributor

@tektaxi tektaxi Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking:
instead of doing this as a list of variables, couldn't lines 28-44 be wrapped into one {} object?
ie. HACKER_REVIEW_STATUSES = {NONE : 'None', POOR : 'Poor', etc.}

HACKER_REVIEWER_STATUS_NONE,
HACKER_REVIEWER_STATUS_POOR,
HACKER_REVIEWER_STATUS_WEAK,
HACKER_REVIEWER_STATUS_AVERAGE,
HACKER_REVIEWER_STATUS_STRONG,
HACKER_REVIEWER_STATUS_OUTSTANDING,
HACKER_REVIEWER_STATUS_WHITELIST,
];

// This date is Jan 6, 2020 00:00:00 GMT -0500
const APPLICATION_CLOSE_TIME = 1578286800000;

Expand Down Expand Up @@ -185,7 +203,15 @@ module.exports = {
HACKER_STATUS_CONFIRMED: HACKER_STATUS_CONFIRMED,
HACKER_STATUS_WITHDRAWN: HACKER_STATUS_WITHDRAWN,
HACKER_STATUS_CHECKED_IN: HACKER_STATUS_CHECKED_IN,
HACKER_REVIEWER_STATUS_NONE: HACKER_REVIEWER_STATUS_NONE,
HACKER_REVIEWER_STATUS_POOR: HACKER_REVIEWER_STATUS_POOR,
HACKER_REVIEWER_STATUS_WEAK: HACKER_REVIEWER_STATUS_WEAK,
HACKER_REVIEWER_STATUS_AVERAGE: HACKER_REVIEWER_STATUS_AVERAGE,
HACKER_REVIEWER_STATUS_STRONG: HACKER_REVIEWER_STATUS_STRONG,
HACKER_REVIEWER_STATUS_OUTSTANDING: HACKER_REVIEWER_STATUS_OUTSTANDING,
HACKER_REVIEWER_STATUS_WHITELIST: HACKER_REVIEWER_STATUS_WHITELIST,
HACKER_STATUSES: HACKER_STATUSES,
HACKER_REVIEWER_STATUSES: HACKER_REVIEWER_STATUSES,
TRAVEL_STATUS_NONE: TRAVEL_STATUS_NONE,
TRAVEL_STATUS_BUS: TRAVEL_STATUS_BUS,
TRAVEL_STATUS_POLICY: TRAVEL_STATUS_POLICY,
Expand Down
20 changes: 20 additions & 0 deletions constants/routes.constant.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,26 @@ const hackerRoutes = {
uri: "/api/hacker/status/" + Constants.ROLE_CATEGORIES.SELF,
_id: mongoose.Types.ObjectId.createFromTime(125)
},
patchAnyReviewerStatusById: {
requestType: Constants.REQUEST_TYPES.PATCH,
uri: "/api/hacker/reviewerStatus/" + Constants.ROLE_CATEGORIES.ALL,
_id: mongoose.Types.ObjectId.createFromTime(168)
},
patchSelfReviewerStatusById: {
requestType: Constants.REQUEST_TYPES.PATCH,
uri: "/api/hacker/reviewerStatus/" + Constants.ROLE_CATEGORIES.SELF,
_id: mongoose.Types.ObjectId.createFromTime(169)
},
patchAnyReviewerStatus2ById: {
requestType: Constants.REQUEST_TYPES.PATCH,
uri: "/api/hacker/reviewerStatus2/" + Constants.ROLE_CATEGORIES.ALL,
_id: mongoose.Types.ObjectId.createFromTime(168)
},
patchSelfReviewerStatus2ById: {
requestType: Constants.REQUEST_TYPES.PATCH,
uri: "/api/hacker/reviewerStatus2/" + Constants.ROLE_CATEGORIES.SELF,
_id: mongoose.Types.ObjectId.createFromTime(169)
},
patchSelfCheckInById: {
requestType: Constants.REQUEST_TYPES.PATCH,
uri: "/api/hacker/checkin/" + Constants.ROLE_CATEGORIES.SELF,
Expand Down
Loading
Loading