-
Notifications
You must be signed in to change notification settings - Fork 444
Adding Stoopid_pad! #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adding Stoopid_pad! #618
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
UnusualTitan711x
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just that we can't see the images in your README file. All links lead to error 404
|
added links to pics from cdn instead! |
|
Nice Job. I approve this. Here's a link to my PR: #405 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! It looks like your board name is in the outline layer. Please make sure it's in the silkscreen layer! Everything else looks good, once this is fixed I'll approve it! Also, please mention your IO expander in the README. Not sure if it goes on the BOM considering you'll be using the grant for it, but please put it somewhere, it's a bit confusing.

Overlord-Runt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hihi, can you move your readme inside your hackpad folder and delete all your libraries?
thank you
Ready to submit your project? Nice job! Hopefully you've read the submission guidelines. If not, make sure to read them first.
Check off the following to let the reviewers know you've done everything:
[X] I HAVE RAN DRC ON MY DESIGN WITH ZERO ERRORS (Silkscreen errors are okay)
[X] I HAVE BRANDED ALL MY PARTS (PCB, CASE) WITH MY HACKPAD'S NAME
[X] I HAVE MADE SURE MY 3D PRINTED PARTS DO NOT REQUIRE SUPPORTS (Text branding overhang is okay)
[X] I HAVE MADE SURE TO INCLUDE TOLERANCES (0.25mm)
[X] MY HACKPAD'S PCB IS UNDER 100mm x 100mm, I DO NOT HAVE MORE THAN 16X SWITCHES, 2X ROTARY ENCODERS, 1X OLED, 16X LEDS.
[X] IN MY FOLDER, THERE IS A README.MD FILE THAT CONTAINS THE FOLLOWING INFORMATION:
If you're unsure about the format, make sure to check out this example and follow the format there.
If this PR isn't a submission, that's okay too! Please remove the above boxes and explain what the pull request is for! If there's anything about this PR template that seems confusing, send a message in #hackpad in slack!