Revert "DRY'd up code, and added general accessors." #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

gtsafas wants to merge 1 commit into master from revert-5-master

Owner

gtsafas commented Dec 26, 2014

Reverts #5


          Revert "DRY'd up code, and added general accessors."

Collaborator

keithbro commented Dec 28, 2014

The items raised by @glorat need to be addressed:

Looks like this PR requires somewhere at least perl 5.10.
No tests
The @IGNORE_DOMAIN logic in _get_route is both a little unobvious and inelegant

Owner Author

gtsafas commented Sep 22, 2015

Sorry @keithbro I merged your other pull req. This looks like it has conflicts now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet