Skip to content

Conversation

@srkethireddy
Copy link
Contributor

Fixing the utilization of the GCE Metadata host server address environment variable to account for the case where the user does not specify a port (defaults to port 8080)

b/451639946

cc: @apolcyn, @anicr7

@srkethireddy srkethireddy marked this pull request as draft November 4, 2025 00:29
@srkethireddy srkethireddy marked this pull request as ready for review November 4, 2025 00:45
@ejona86
Copy link
Member

ejona86 commented Nov 5, 2025

/gcbrun

@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Nov 5, 2025
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Nov 5, 2025
@ejona86
Copy link
Member

ejona86 commented Nov 10, 2025

@apolcyn, @anicr7, the logic here has become more subtle. We're supposed to release tomorrow, and this still seems a few days away from full testing. I'm wary of including it is the release.

@srkethireddy
Copy link
Contributor Author

Changed the utilization of the GCE Metadata host server address environment variable so that if a port is specified or unspecified, it defaults to use port 8080 for ALTS handshake.

Tested scenarios where environment variable was not set, environment variable was set but with no port, and environment variable was set with a port other than 8080

@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Nov 11, 2025
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Nov 11, 2025
@ejona86
Copy link
Member

ejona86 commented Nov 11, 2025

/gcbrun

@ejona86 ejona86 added the TODO:backport PR needs to be backported. Removed after backport complete label Nov 12, 2025
@ejona86
Copy link
Member

ejona86 commented Nov 12, 2025

The testing got completed sooner than originally believed, so I'm good with this now.

@ejona86 ejona86 merged commit e2d5bad into grpc:master Nov 12, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

TODO:backport PR needs to be backported. Removed after backport complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants