-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Servers must preserve lexical ordering between SDL and introspection #673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e5d241d to
6c81ed8
Compare
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
I approve of the intent behind this. It doesn't feel like putting the current proposed edit in chapter 4 is quite right though. We have effectively this global rule:
Then that comes with two corollaries:
(1) Should be in section 3 ("Type System"), whereas (2) should be in section 4 ("Introspection"). I think (2) should come under each of the
Similar localised edits should be made in section 3 I think. I'm not sure where the global rule belongs exactly, it could be that section 3 covers it. |
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I believe this pull request is superseded by #1092, thus I am closing. |
Resolves #577
This change adds the proposed addition by @leebyron from #577 (comment)