fix UnicodeDecodeError in format_error #216 (#223)

Author: chinskiy

graphql/error/format_error.py

@@ -1,5 +1,3 @@
-from six import text_type
-
 from .base import GraphQLError
 
 # Necessary for static type checking
@@ -9,7 +7,12 @@
 
 def format_error(error):
     # type: (Exception) -> Dict[str, Any]
-    formatted_error = {"message": text_type(error)}  # type: Dict[str, Any]
+    # Protect against UnicodeEncodeError when run in py2 (#216)
+    try:
+        message = str(error)
+    except UnicodeEncodeError:
+        message = error.message.encode("utf-8")  # type: ignore
+    formatted_error = {"message": message}  # type: Dict[str, Any]
     if isinstance(error, GraphQLError):
         if error.locations is not None:
             formatted_error["locations"] = [

graphql/execution/tests/test_format_error.py

@@ -0,0 +1,16 @@
+# coding: utf-8
+import pytest
+
+from graphql.error import GraphQLError, format_error
+
+
+@pytest.mark.parametrize(
+    "error",
+    [
+        GraphQLError("UNIÇODÉ!"),
+        GraphQLError("\xd0\xbe\xd1\x88\xd0\xb8\xd0\xb1\xd0\xba\xd0\xb0"),
+    ],
+)
+def test_unicode_format_error(error):
+    # type: (GraphQLError) -> None
+    assert isinstance(format_error(error), dict)