feat(gateway): add support for new Hive CDN mirror and circuit breaker #1738

EmrysMyrddin · 2025-11-27T15:39:02Z

Description

Adds support for the new Hive CDN fetcher with the addition of a secondary mirror and a circuit breaker.

Details

This PR also ensures the schema fetcher is actually disposed, since the circuit breaker has to be disposed to properly shut down the gateway.

Ref GW-535

Todo

add mirror and circuit breaker options for schema fetcher
dispose fetcher on gateway disposal
add mirror and circuit breaker for Persisted Documents
use Hive Logger in all Hive related features

gemini-code-assist · 2025-11-27T15:39:19Z

Summary of Changes

Hello @EmrysMyrddin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly upgrades the gateway's schema fetching capabilities by introducing support for a new Hive CDN fetcher. This enhancement includes the addition of a secondary CDN mirror for improved resilience and the integration of a circuit breaker mechanism to prevent service degradation during upstream issues. Furthermore, it ensures that all components, particularly the circuit breaker, are properly disposed of when the gateway shuts down, contributing to overall system stability.

Highlights

Hive CDN Mirror Support: The gateway now supports a secondary mirror for the Hive CDN, enhancing reliability and availability of schema fetching.
Circuit Breaker Implementation: A circuit breaker has been integrated into the Hive CDN fetcher, providing fault tolerance and preventing cascading failures.
Proper Schema Fetcher Disposal: The schema fetcher, including the new circuit breaker, is now correctly disposed of during gateway shutdown, ensuring clean resource release.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces support for a secondary CDN mirror and a circuit breaker for Hive, enhancing the reliability of schema fetching. The changes primarily involve refactoring the schema and supergraph fetchers to use the new createCDNArtifactFetcher and to properly handle disposal of resources, which is a great improvement for graceful shutdown. I've identified a minor bug in URL manipulation and a couple of areas where the implementation could be safer and more readable. Overall, this is a solid feature addition.

gemini-code-assist · 2025-11-27T15:41:31Z

packages/runtime/src/createGatewayRuntime.ts

+            ? url
+            : joinUrl(
+                url.endsWith('/services')
+                  ? url.substring(0, url.length - 8)


There seems to be a small off-by-one error here. The length of '/services' is 9, but you are subtracting 8. This will leave a trailing slash in the URL before it's passed to joinUrl. While joinUrl might handle this gracefully, it's more precise to subtract the correct length to avoid potential issues.

Suggested change

? url.substring(0, url.length - 8)

? url.substring(0, url.length - 9)

gemini-code-assist · 2025-11-27T15:41:31Z

packages/runtime/src/createGatewayRuntime.ts

+              ),
+      );
+      const fetcher = createCDNArtifactFetcher({
+        endpoint: endpoints as [string, string],


The type assertion as [string, string] is not always correct. When a single endpoint string is provided in the configuration, the endpoints array will only contain one element. This cast can hide a type mismatch and lead to potential runtime errors if createCDNArtifactFetcher expects a tuple of two strings. A more accurate type assertion would be safer.

Suggested change

endpoint: endpoints as [string, string],

endpoint: endpoints as [string, ...string[]],

gemini-code-assist · 2025-11-27T15:41:31Z

packages/runtime/src/createGatewayRuntime.ts

+        );

+        const fetcher = createCDNArtifactFetcher({
+          endpoint: endpoints as [string, string],


Similar to the other usage of createCDNArtifactFetcher, the type assertion as [string, string] is not always correct here. If a single endpoint string is provided, the endpoints array will have only one element. This could lead to runtime issues. A more accurate type assertion would be safer.

Suggested change

endpoint: endpoints as [string, string],

endpoint: endpoints as [string, ...string[]],

packages/runtime/src/createGatewayRuntime.ts

theguild-bot · 2025-11-27T15:42:04Z

🚀 Snapshot Release (`alpha`)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package	Version	Info
`@graphql-tools/batch-delegate`	`10.0.6-alpha-bad695e6dd6ff62553b712e1629b8f6578032c4d`	npm ↗︎ unpkg ↗︎
`@graphql-tools/delegate`	`12.0.0-alpha-bad695e6dd6ff62553b712e1629b8f6578032c4d`	npm ↗︎ unpkg ↗︎
`@graphql-tools/federation`	`4.2.4-alpha-bad695e6dd6ff62553b712e1629b8f6578032c4d`	npm ↗︎ unpkg ↗︎
`@graphql-mesh/fusion-runtime`	`1.6.0-alpha-bad695e6dd6ff62553b712e1629b8f6578032c4d`	npm ↗︎ unpkg ↗︎
`@graphql-hive/gateway`	`2.1.20-alpha-bad695e6dd6ff62553b712e1629b8f6578032c4d`	npm ↗︎ unpkg ↗︎
`@graphql-hive/nestjs`	`2.0.25-alpha-bad695e6dd6ff62553b712e1629b8f6578032c4d`	npm ↗︎ unpkg ↗︎
`@graphql-hive/plugin-aws-sigv4`	`2.0.18-alpha-bad695e6dd6ff62553b712e1629b8f6578032c4d`	npm ↗︎ unpkg ↗︎
`@graphql-hive/plugin-opentelemetry`	`1.2.2-alpha-bad695e6dd6ff62553b712e1629b8f6578032c4d`	npm ↗︎ unpkg ↗︎
`@graphql-mesh/plugin-prometheus`	`2.1.6-alpha-bad695e6dd6ff62553b712e1629b8f6578032c4d`	npm ↗︎ unpkg ↗︎
`@graphql-hive/router-runtime`	`1.1.0-alpha-bad695e6dd6ff62553b712e1629b8f6578032c4d`	npm ↗︎ unpkg ↗︎
`@graphql-hive/gateway-runtime`	`2.4.0-alpha-bad695e6dd6ff62553b712e1629b8f6578032c4d`	npm ↗︎ unpkg ↗︎
`@graphql-tools/stitch`	`10.1.4-alpha-bad695e6dd6ff62553b712e1629b8f6578032c4d`	npm ↗︎ unpkg ↗︎
`@graphql-tools/stitching-directives`	`4.0.6-alpha-bad695e6dd6ff62553b712e1629b8f6578032c4d`	npm ↗︎ unpkg ↗︎
`@graphql-hive/gateway-testing`	`3.0.0-alpha-bad695e6dd6ff62553b712e1629b8f6578032c4d`	npm ↗︎ unpkg ↗︎
`@graphql-tools/wrap`	`11.1.0-alpha-bad695e6dd6ff62553b712e1629b8f6578032c4d`	npm ↗︎ unpkg ↗︎

theguild-bot · 2025-11-27T15:45:44Z

🚀 Snapshot Release (Binary for `Linux-X64`)

The latest changes of this PR are available for download (based on the declared changesets).

theguild-bot · 2025-11-27T15:45:46Z

🚀 Snapshot Release (Binary for `macOS-ARM64`)

The latest changes of this PR are available for download (based on the declared changesets).

theguild-bot · 2025-11-27T15:46:17Z

🚀 Snapshot Release (Binary for `Linux-ARM64`)

The latest changes of this PR are available for download (based on the declared changesets).

ardatan · 2025-11-27T15:48:53Z

packages/runtime/src/createGatewayRuntime.ts

+        );

+        const fetcher = createCDNArtifactFetcher({
+          endpoint: endpoints as [string, string],


Maybe asArray can be used here instead of casting.

ardatan · 2025-11-27T15:49:14Z

packages/runtime/src/createGatewayRuntime.ts

        }
      },
-      onDispose() {
+      async onDispose() {


Suggested change

async onDispose() {

onDispose() {

ardatan · 2025-11-27T15:49:53Z

packages/runtime/src/createGatewayRuntime.ts

+      async onDispose() {
        pausePolling();
-        return transportExecutorStack.disposeAsync();
+        await transportExecutorStack.disposeAsync();


Suggested change

await transportExecutorStack.disposeAsync();

return handleMaybePromise(() => transportExecutorStack.disposeAsync(), () => schemaFetcher.dispose?.());

I've used async/await here because disposeAsync type advertises that it always return a Promise, so I'm not sure handleMaybePromise is needed?

theguild-bot · 2025-11-27T15:52:38Z

🚀 Snapshot Release (Node Docker Image)

The latest changes of this PR are available as image on GitHub Container Registry (based on the declared changesets):

ghcr.io/graphql-hive/gateway:2.1.20-alpha-bad695e6dd6ff62553b712e1629b8f6578032c4d

theguild-bot · 2025-11-27T15:52:43Z

🚀 Snapshot Release (Bun Docker Image)

The latest changes of this PR are available as image on GitHub Container Registry (based on the declared changesets):

ghcr.io/graphql-hive/gateway:2.1.20-alpha-bad695e6dd6ff62553b712e1629b8f6578032c4d-bun

theguild-bot · 2025-11-27T15:53:46Z

🚀 Snapshot Release (Binary for `Windows-X64`)

The latest changes of this PR are available for download (based on the declared changesets).

theguild-bot · 2025-11-27T15:53:55Z

🚀 Snapshot Release (Binary for `macOS-X64`)

The latest changes of this PR are available for download (based on the declared changesets).

n1ru4l · 2025-11-27T16:51:25Z

Since it is not in the todos: Just to make sure: the mirror must also be providable for persisted documents

EmrysMyrddin · 2025-12-01T10:52:48Z

Waiting for graphql-hive/console#7287 to be released first

enisdenjo

A few small remarks, otherwise looking good.

enisdenjo · 2025-12-01T11:07:10Z

.changeset/cold-bags-confess.md

+'@graphql-hive/gateway-runtime': minor
+---
+
+## New Hive CDN mirror and circuit breaker


First line should be the name of the changeset, dont title it, it will look weird when listing all changesets.

enisdenjo · 2025-12-01T11:10:14Z

package.json

    "vitest": "3.2.4"
  },
  "resolutions": {
+    "@graphql-hive/core": "0.16.0-alpha-20251126142740-d265dc6d6d73bf62ec597dbe41409f466b9d9874",


Was this released? Do we want the alpha?

enisdenjo · 2025-12-01T11:11:26Z

packages/runtime/src/createGatewayRuntime.ts

+        const endpoints = (Array.isArray(endpoint) ? endpoint : [endpoint]).map(
+          (url) => (url.endsWith('/supergraph') ? url : `${url}/supergraph`),
+        );


Why are we doing this in the gateway? Shouldn't the supergraph fetcher handle this instead?

Because It was handled by the schema fetcher before, not anymore (because there is no schema fetcher anymore, it's a generic artifacts fetcher)

So it's just to avoid a breaking change on our end

n1ru4l · 2025-12-01T14:46:33Z

Do you have understanding whether people use the config or CLI parameters for providing the configuration, and whether it should also be possible to provide these by other means than the config?

EmrysMyrddin · 2025-12-01T14:55:05Z

We can probably make the endpoint a multiple flag, so that you can provide more than one.

For the circuit breaker, seems a bit advanced to have it as CLI flag, but we can introduce env variables if you want ?

n1ru4l · 2025-12-01T17:01:16Z

Oh, I was only referring towards the endpoint option, sorry for the confusion! I think most (read as: probably all) people should not configure circuit breaker and use the defaults, I don't see a need to make this a CLI parameter.

For the endpoint it might make sense. I am fine with omitting this here and making it a follow up pull request. I have no clue if people provide this via CLI or config file

EmrysMyrddin marked this pull request as draft November 27, 2025 15:39

gemini-code-assist bot reviewed Nov 27, 2025

View reviewed changes

ardatan reviewed Nov 27, 2025

View reviewed changes

EmrysMyrddin marked this pull request as ready for review November 28, 2025 09:41

EmrysMyrddin force-pushed the hive-cdn-mirror branch from a27a06b to 00eb94d Compare November 28, 2025 09:41

n1ru4l approved these changes Nov 28, 2025

View reviewed changes

EmrysMyrddin added 8 commits November 29, 2025 10:01

feat(gateway): add support for new Hive CDN mirror and circuit breaker

cbb2d78

add mirror and circuit breaker to persisted documents

f6395ed

fix missing circuit breaker when usage report entabled

761959d

add changeset

8deb1d4

format

c46a189

fix tests

bac47b3

fix e2e tests for hive usage

dc5e9ec

try to fix wrangler config

bad695e

EmrysMyrddin force-pushed the hive-cdn-mirror branch from 69c4d19 to bad695e Compare November 29, 2025 09:01

EmrysMyrddin enabled auto-merge (squash) December 1, 2025 09:55

EmrysMyrddin disabled auto-merge December 1, 2025 09:55

enisdenjo requested changes Dec 1, 2025

View reviewed changes

	? url.substring(0, url.length - 8)
	? url.substring(0, url.length - 9)

	endpoint: endpoints as [string, string],
	endpoint: endpoints as [string, ...string[]],

	await transportExecutorStack.disposeAsync();
	return handleMaybePromise(() => transportExecutorStack.disposeAsync(), () => schemaFetcher.dispose?.());

feat(gateway): add support for new Hive CDN mirror and circuit breaker #1738

Are you sure you want to change the base?

feat(gateway): add support for new Hive CDN mirror and circuit breaker #1738

Uh oh!

Conversation

EmrysMyrddin commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Details

Todo

Uh oh!

gemini-code-assist bot commented Nov 27, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

theguild-bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (alpha)

Uh oh!

theguild-bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (Binary for Linux-X64)

Uh oh!

theguild-bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (Binary for macOS-ARM64)

Uh oh!

theguild-bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (Binary for Linux-ARM64)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

theguild-bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (Node Docker Image)

Uh oh!

theguild-bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (Bun Docker Image)

Uh oh!

theguild-bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (Binary for Windows-X64)

Uh oh!

theguild-bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (Binary for macOS-X64)

Uh oh!

n1ru4l commented Nov 27, 2025

Uh oh!

EmrysMyrddin commented Dec 1, 2025

Uh oh!

enisdenjo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

EmrysMyrddin commented Nov 27, 2025 •

edited

Loading

theguild-bot commented Nov 27, 2025 •

edited

Loading

🚀 Snapshot Release (`alpha`)

theguild-bot commented Nov 27, 2025 •

edited

Loading

🚀 Snapshot Release (Binary for `Linux-X64`)

theguild-bot commented Nov 27, 2025 •

edited

Loading

🚀 Snapshot Release (Binary for `macOS-ARM64`)

theguild-bot commented Nov 27, 2025 •

edited

Loading

🚀 Snapshot Release (Binary for `Linux-ARM64`)

theguild-bot commented Nov 27, 2025 •

edited

Loading

theguild-bot commented Nov 27, 2025 •

edited

Loading

theguild-bot commented Nov 27, 2025 •

edited

Loading

🚀 Snapshot Release (Binary for `Windows-X64`)

theguild-bot commented Nov 27, 2025 •

edited

Loading

🚀 Snapshot Release (Binary for `macOS-X64`)