feat: Resolve memcached servers #1627
Open
+623
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to allow the user to pass a hostname on the command line (that might resolve to multiple IP addresses), perform DNS resolution when creating the Memcached client. The servers are resolved again on a periodic basis to account for possible changes in IP addresses (as might happen in a k8s cluster). Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
mem
force-pushed
the
mem/resolve-memcached-addresses
branch
from
372b8d5 to
2d6bcd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow the user to pass a hostname on the command line (that might resolve to multiple IP addresses), perform DNS resolution when creating the Memcached client. The servers are resolved again on a periodic basis to account for possible changes in IP addresses (as might happen in a k8s cluster).