-
Notifications
You must be signed in to change notification settings - Fork 711
feat: Scalable Compactor #2466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: Scalable Compactor #2466
Changes from all commits
Commits
Show all changes
94 commits
Select commit
Hold shift + click to select a range
6020102
storage: Refactor block compaction to allow shard-splitting
cyriltovena 63d1beb
Rename to CompactWithSplitting for consistency
cyriltovena 8129c06
Introduce back compaction series testing.
cyriltovena cb310f8
Add sharding compaction level
cyriltovena 64d22fd
Add some tests for CompactWithSplitting
cyriltovena 22d6271
Fix symbols split-compaction (#2371)
kolesnikovae 6a56550
Merge remote-tracking branch 'origin/main' into feat/split-compaction
cyriltovena 816eaaa
Fixes a race that was actually surfacing another real issue.
cyriltovena d100b30
Add a tests for meta min/max time
cyriltovena bd4f5e7
Fixes meta min/max after split
cyriltovena cbcf90a
Add mimir compactor code
cyriltovena f297930
Fixing more code
cyriltovena a26efaf
Introduce a meta fetcher that synchronize filtered metadata of all bl…
cyriltovena 14c47f8
Fixes all tests
cyriltovena 1ea5c6f
Merge branch 'main' into feat/meta-fetcher
cyriltovena 9de29ce
make go/mod
cyriltovena 6a27699
Merge branch 'feat/meta-fetcher' into feat/compactor-component
cyriltovena e3930f0
Adds a tenant scanner
cyriltovena a5235c7
Merge branch 'feat/tenant-scanner' into feat/compactor-component
cyriltovena 26979c4
Working on the blocks cleaner
cyriltovena 91ae0c1
Merge remote-tracking branch 'origin/main' into feat/compactor-component
cyriltovena c0cee89
Merge remote-tracking branch 'origin/main' into feat/compactor-component
cyriltovena 56187ba
Adds bucketindex package
cyriltovena a29953e
Merge branch 'feat/bucketindex' into feat/compactor-component
cyriltovena d61cbd5
Fixing and adapting more code
cyriltovena 171c960
Add missing minCompactor config
cyriltovena 1650aba
Fixes as much as possible
cyriltovena 54a37cf
block: Adds Download and MarkForNoCompact
cyriltovena 08abae6
improve documentation
cyriltovena c0f98cb
Merge branch 'feat/download.block' into feat/compactor-component
cyriltovena e99562c
wip
cyriltovena f88b292
Adds a way to validate local blocks
cyriltovena b8c6cad
Merge branch 'feat/validateblock2' into feat/compactor-component
cyriltovena 3324acc
fixes wrong merge
cyriltovena 07bc118
more integration fixes
cyriltovena 8595c64
fixes metrics namespace
cyriltovena 0fa0966
more fixes
cyriltovena 34ed7c6
fixes block_cleaner_test
cyriltovena 0647cd9
remove upload block api
cyriltovena 4f88161
Fixes split_merge_compactor tests
cyriltovena 69532be
Fixes split_merge_compactor tests
cyriltovena e97e1fe
Fixes more tests
cyriltovena c461b89
fixing more tests
cyriltovena 89fd201
Merge remote-tracking branch 'origin/main' into feat/compactor-component
cyriltovena 04b2a61
Fixes more tests
cyriltovena 66b0b37
Add limits for the compactor
cyriltovena 53e5147
Removes unused limits and code
cyriltovena 37df961
Switches to Compactor interface for mocking
cyriltovena 091ee65
Fixes blocks_cleaner_test.go
cyriltovena 40a4368
Removes tombstones removal
cyriltovena 8f0d8d6
Merge remote-tracking branch 'origin/main' into feat/compactor-component
cyriltovena c8dad64
Fixes the compactor shard label not being saved
cyriltovena cc3c2ea
Fixes most compactor tests.
cyriltovena 0a1d6d9
Implement e2e tests
cyriltovena d2226c1
lint
cyriltovena 50624bd
Merge remote-tracking branch 'origin/main' into feat/compactor-component
cyriltovena c946b9c
Merge remote-tracking branch 'origin/main' into feat/compactor-component
cyriltovena 19ddfcc
Fixes a race detected when generating ULID
cyriltovena 333520d
Merge branch 'bugfix/race-ulid' into feat/compactor-component
cyriltovena 237cf4f
Add the compactor compenent
cyriltovena dd2612e
Add the compactor helm component
cyriltovena d6d000c
Fixes tests after the range change
cyriltovena 22ccdcd
change: store-gateway uses the bucketindex
cyriltovena ab041e3
Fixes helm to not use a disk
cyriltovena 17159a6
Use stable time format for logs
cyriltovena 2db23f0
Fixes time format issue
cyriltovena 1518b3f
Changes the default compactor dir
cyriltovena c7b5a36
Fixes panic while rewriting symbols.
cyriltovena 26e546a
Fixes mark global path and add 8h compaction range
cyriltovena ac099ca
Fixes store-gateway local cache.
cyriltovena 9860bbf
Fixes store-gateway stale meta
cyriltovena 20d05b4
Merge commit '9fda0ce2c5cc52795204c3d336bbe74aed0000e9' into feat/com…
cyriltovena 4a1aa95
Add compaction metrics
cyriltovena 4a1ccf7
Fixes panic in compaction metrics
cyriltovena 4576fed
Discard __hostname__ labels from block for compaction planning
cyriltovena 7f99a27
Improves parquet profile file reader
cyriltovena 33a9fc0
Fixes more broken tests
cyriltovena 5a3efd7
Merge remote-tracking branch 'origin/main' into feat/compactor-component
cyriltovena d0a13a3
Makes configurable the split by compaction
cyriltovena bf9f143
lint
cyriltovena 902772c
Merge remote-tracking branch 'origin/main' into feat/compactor-component
cyriltovena 97e11c7
Correct compaction range for the current default
cyriltovena 191e2c0
review feedback first round
cyriltovena 97ffb57
Merge remote-tracking branch 'origin/main' into feat/compactor-component
cyriltovena 802781c
make helm/check
cyriltovena e242ed0
ULID are now based on minTime
cyriltovena e68b718
Use model.Time for parent block meta
cyriltovena 195f5eb
Fixes broken tests from previous commit
cyriltovena 76823dc
Validates that the first compaction range is divisible by the block d…
cyriltovena 642c4cb
Merge remote-tracking branch 'origin/main' into feat/compactor-component
cyriltovena 4b33d38
Add filesystem tests for delete block
cyriltovena 4128047
Fixes tests
cyriltovena 8309bba
Merge remote-tracking branch 'origin/main' into feat/compactor-component
cyriltovena 0ffe8c8
Convert profiles rows when compacting to ensure backward compatibility
cyriltovena File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.