Fix(NotificationPolicy): Remove invalid fields under .spec.route
#2270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes a fields from .spec.route preventing users from defining them and ending up with an invalid API request/DTO Additionally, .spec.provenance is deprecated as it seemingly does nothing
github-actions
bot
added
documentation
|
This PR hasn't been updated for a while, marking as stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the solution found in: 2208
Funnily enough, the official docs are wrong on what the API accepts:
But the Grafana Terraform provider correctly splits the relevant fields out from the Route: