Skip to content

fix: Check for undefined faro instancein isWebStorageAvailable catch block #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Check for undefined faro instancein isWebStorageAvailable catch block #757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/web-sdk/src/utils/webStorage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ export function isWebStorageAvailable(type: StorageMechanism): boolean {
return true;
} catch (error) {
// the above can throw
faro.internalLogger?.info(`Web storage of type ${type} is not available. Reason: ${error}`);
// this is called during module init, when the global instance may not be available
Copy link
Collaborator

@kpelelis kpelelis Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not necessarily called during global module init if you would be able to rephrase the comment for clarity.

faro?.internalLogger?.info(`Web storage of type ${type} is not available. Reason: ${error}`);
return false;
}
}
Expand Down
Loading