feat: multiplexed session as default session mode #2451

alkatrivedi · 2025-10-31T06:31:44Z

This PR contains code changes for making multiplexed session as default enabled session mode.

To disable the multiplexed session:
For RO Transactions -
GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS = 'false'

For Partitioned DML -

GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS = 'false'
GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS_PARTITIONED_OPS = 'false'

For RW Transactions -

GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS = 'false'
GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS_FOR_RW = 'false'

Additionally, this PR includes code changes in the kokoro pipeline to run the integration test against regular sessions.

generated-files-bot · 2025-11-05T08:26:30Z

Warning: This pull request is touching the following templated files:

.kokoro/presubmit/node18/system-test-regular-session.cfg - .kokoro files are templated and should be updated in synthtool

alkatrivedi · 2025-11-05T11:10:17Z

test/spanner.ts

          }
        },
      );
+      // awaiting 10ms for begin call to finish its execution


since we are not awaiting on begin in createReadStream(known issue) to finish its execution, which was resulting in beginTxnRequest to be undefined. hence having this 10ms of sleep

src/index.ts

alkatrivedi · 2025-11-05T11:28:13Z

src/multiplexed-session.ts

   */
  async _acquire(): Promise<Session | null> {
+    const span = getActiveOrNoopSpan();
+    span.addEvent('Acquiring multiplexed session');


have added these events for multiplexed session similar to we had for regular sessions

nit: I feel these events are not required. For regular session it was required as there was a wait if the session is not available. We already have few events in _getSession for mux sessions

observability-test/spanner.ts

src/multiplexed-session.ts

src/index.ts

surbhigarg92 · 2025-11-11T06:21:28Z

src/multiplexed-session.ts

   */
  async _acquire(): Promise<Session | null> {
+    const span = getActiveOrNoopSpan();
+    span.addEvent('Acquiring multiplexed session');


nit: I feel these events are not required. For regular session it was required as there was a wait if the session is not available. We already have few events in _getSession for mux sessions

surbhigarg92 · 2025-11-11T06:24:06Z

test/database.ts

-      const error = new Error('err');
-
-      const sessionFactory = new SessionFactory(database, NAME);
+    describe('when multiplexed session is disabled', () => {


IIRC, we decided to remove these tests to remove the complexity.

We've refactored the tests to focus on the default multiplexed mode and removed the complex env enable/disable permutation loops.

For the regular session-specific tests, we can just run them with GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS disabled. Since we aren't running the full matrix of env permutations anymore. IMO we can retain this test. WDYT?

Sure. Make sure to verify if we are reverting the ENVs in after block

yeah, that I have made sure!

alkatrivedi requested review from a team as code owners October 31, 2025 06:31

alkatrivedi marked this pull request as draft October 31, 2025 06:31

product-auto-label bot added size: xl Pull request size is extra large. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Oct 31, 2025

alkatrivedi force-pushed the mux-default-enabled branch 3 times, most recently from 3bdd009 to e3ab09e Compare November 5, 2025 04:04

alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 5, 2025

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 5, 2025

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 5, 2025

alkatrivedi force-pushed the mux-default-enabled branch from 242bb79 to ffc787e Compare November 5, 2025 08:26

alkatrivedi force-pushed the mux-default-enabled branch 3 times, most recently from e28ae67 to eb48211 Compare November 5, 2025 08:39

alkatrivedi added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 5, 2025

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 5, 2025

alkatrivedi force-pushed the mux-default-enabled branch from eb48211 to d5411fb Compare November 5, 2025 10:52

alkatrivedi commented Nov 5, 2025

View reviewed changes

src/index.ts Show resolved Hide resolved

alkatrivedi commented Nov 5, 2025

View reviewed changes

alkatrivedi added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 5, 2025

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 5, 2025

alkatrivedi force-pushed the mux-default-enabled branch from d5411fb to 82ff2b5 Compare November 5, 2025 19:12

alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 5, 2025

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 5, 2025

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 5, 2025

alkatrivedi marked this pull request as ready for review November 6, 2025 04:34

alkatrivedi added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 6, 2025

surbhigarg92 reviewed Nov 11, 2025

View reviewed changes

feat: multiplexed session as default session mode

635e6c7

alkatrivedi force-pushed the mux-default-enabled branch from 82ff2b5 to 635e6c7 Compare November 11, 2025 08:45

alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 11, 2025

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 11, 2025

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2025

surbhigarg92 approved these changes Nov 11, 2025

View reviewed changes

alkatrivedi merged commit 9ef0565 into main Nov 11, 2025
22 of 25 checks passed

alkatrivedi deleted the mux-default-enabled branch November 11, 2025 20:14

release-please bot mentioned this pull request Nov 10, 2025

chore(main): release 8.3.0 #2447

Merged

feat: multiplexed session as default session mode #2451

feat: multiplexed session as default session mode #2451

Uh oh!

Conversation

alkatrivedi commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

generated-files-bot bot commented Nov 5, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alkatrivedi commented Oct 31, 2025 •

edited

Loading