-
Notifications
You must be signed in to change notification settings - Fork 68
feat: resource autodetection for Cloud Run Jobs #1591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@bhshkh Is there something I should do to rectify this? These errors look maybe related to #1599? Also googleapis/google-auth-library-nodejs#2120 got merged, so I could bump |
@cindy-peng should be able to answer this. |
|
Ping @cindy-peng |
|
Tagging @danieljbruce @feywind |
|
Ping. |
|
Hi @Daniel-Aaron-Bloom! thanks for your help on this. Yes, I think upgrading auth is the most proper solution + will help with #1592. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Unfortunately
google-auth-librarydoesn't yet support Cloud Run Job detection. The workaround is pretty simple (basically the same as #1024 did by checking the env directly). Happy to submit a future PR to do the "more correct" detection once support gets merged. Maybe someone here knows an approver over there 😁 .Fixes #1590 🦕