Skip to content

Conversation

@workservice-dev
Copy link
Contributor

@workservice-dev workservice-dev commented Dec 2, 2025

Closing this PR — no longer necessary. Cleaning up unused branch

@google-cla
Copy link

google-cla bot commented Dec 2, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jbduncan
Copy link
Contributor

jbduncan commented Dec 3, 2025

The class, enum and method Javadocs describe things rather well and there is a package-level Javadoc already in package-info.java which the Javadoc proposed in this PR conflicts with. Can you shed some light on this?

@cpovirk cpovirk closed this Dec 3, 2025
@jbduncan
Copy link
Contributor

jbduncan commented Dec 3, 2025

@GuilhermeWBO Which tool was this? I think you'll find that no other class in Guava has package-level docs, just the package-info.java files has them. So I'm afraid it sounds like a bug that you should report to the authors.

I'm sure that @cpovirk and the other Guava maintainers would agree with me on this.

That being said, thank you so much for your contribution anyway! Guava isn't the easiest Java project to contribute to - Apache Commons, which is in the same space, is easier to get into - but if you find any other small things like typos and bugs, I'm sure the team would be happy to review it. :)

@jbduncan
Copy link
Contributor

jbduncan commented Dec 3, 2025

(I will also say, it looks like the PR was generated with ChatGPT, intentionally or otherwise, which was probably a contributing factor to why it was closed unceremoniously. 😉)

@workservice-dev workservice-dev deleted the pr-add-javadoc-caseformat branch December 3, 2025 18:28
@workservice-dev workservice-dev changed the title Add missing Javadoc to CaseFormat class to improve documentation Closed PR — no longer needed Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants