sync: don't call Done when f() panics in WaitGroup.Go #76172

callthingsoff · 2025-11-04T17:28:13Z

This change is based on
#76126 (comment)
by adonovan.

Fixes #76126
Fixes #74702

gopherbot · 2025-11-04T17:41:07Z

This PR (HEAD: fa112c3) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/717760.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-11-04T18:35:48Z

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-04T20:33:21Z

Message from Alan Donovan:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T09:48:59Z

This PR (HEAD: 5bd20b8) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/717760.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-11-05T17:10:41Z

Message from Jes Cok:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T17:37:48Z

Message from Alan Donovan:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T18:03:11Z

Message from Ian Lance Taylor:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T18:46:03Z

Message from Jes Cok:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T19:29:12Z

This PR (HEAD: 24e36fb) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/717760.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-11-05T19:37:35Z

Message from Jes Cok:

Patch Set 3: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T19:46:00Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-11-05T19:30:24Z","revision":"47b46847c44845ce9183780c45ba7bf9d4fa400c"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T19:54:21Z

Message from Jes Cok:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T19:54:22Z

Message from Go LUCI:

Patch Set 3:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-amd64_avx512 has failed with summary (view all results):

go on master (change 717760)

To reproduce, try gomote repro 8699013750259103089.

Additional links for debugging:

go tool dist test -json output [shard 1]

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T19:54:23Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T20:11:13Z

Message from Sean Liao:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T20:19:45Z

Message from Alan Donovan:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T21:43:30Z

This PR (HEAD: eedf805) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/717760.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-11-05T22:15:53Z

Message from Jes Cok:

Patch Set 4: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T22:15:53Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-11-05T22:07:13Z","revision":"960bf20b4875a3747bc85171f0cdf6dcebc50ce7"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T22:33:18Z

Message from Jes Cok:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T22:33:19Z

Message from Go LUCI:

Patch Set 4:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-js-wasm has failed with summary (view all results):

go on master (change 717760)

To reproduce, try gomote repro 8699003881059516497.

Additional links for debugging:

go tool dist test -json output [shard 1]

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T22:33:19Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T22:33:27Z

This PR (HEAD: fb39447) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/717760.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-11-05T22:41:41Z

Message from Jes Cok:

Patch Set 5: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-07T22:24:24Z

Message from Jes Cok:

Patch Set 9: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-07T22:24:25Z

Message from Go LUCI:

Patch Set 9:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-11-07T22:15:12Z","revision":"8930e0feb033d4ef2dbd33ee69515bd5d4d06e0c"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-07T22:39:54Z

Message from Jes Cok:

Patch Set 9: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-07T22:39:55Z

Message from Go LUCI:

Patch Set 9:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-amd64_avx512 has failed with summary (view all results):

go on master (change 717760)

To reproduce, try gomote repro 8698822189065388177.

Additional links for debugging:

go tool dist test -json output [shard 4]

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-07T22:39:55Z

Message from Go LUCI:

Patch Set 9: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-07T22:55:32Z

Message from Jes Cok:

Patch Set 9: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-07T22:55:33Z

Message from Go LUCI:

Patch Set 9:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-11-07T22:47:50Z","revision":"8930e0feb033d4ef2dbd33ee69515bd5d4d06e0c"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-07T23:10:32Z

Message from Jes Cok:

Patch Set 9: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-07T23:10:33Z

Message from Go LUCI:

Patch Set 9:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-07T23:10:33Z

Message from Go LUCI:

Patch Set 9: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-08T11:58:05Z

Message from qiu laidongfeng:

Patch Set 9: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

This is a copy-paste of golang#76126 (comment) by adonovan. Fixes golang#76126 Fixes golang#74702

gopherbot · 2025-11-10T09:28:20Z

This PR (HEAD: b1beddc) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/717760.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-11-10T09:36:53Z

Message from Jes Cok:

Patch Set 10: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-10T09:45:29Z

Message from Go LUCI:

Patch Set 10:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-11-10T09:29:06Z","revision":"9e918d0de709a64e2d3402758eac2b88536a1cd2"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-10T10:02:44Z

Message from Jes Cok:

Patch Set 10: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-10T10:02:44Z

Message from Go LUCI:

Patch Set 10:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-10T10:02:45Z

Message from Go LUCI:

Patch Set 10: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-10T10:54:29Z

Message from Jes Cok:

Patch Set 10:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-10T11:53:14Z

Message from Mateusz Poliwczak:

Patch Set 10: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-10T12:47:00Z

Message from Alan Donovan:

Patch Set 10: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/717760.
After addressing review feedback, remember to publish your drafts!

This change is based on #76126 (comment) by adonovan. Fixes #76126 Fixes #74702 Change-Id: Ie404d8204be8917fa8a7b414bb6d319238267c83 GitHub-Last-Rev: b1beddc GitHub-Pull-Request: #76172 Reviewed-on: https://go-review.googlesource.com/c/go/+/717760 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Mateusz Poliwczak <mpoliwczak34@gmail.com> Auto-Submit: Michael Pratt <mpratt@google.com> Reviewed-by: Alan Donovan <adonovan@google.com> Reviewed-by: Michael Pratt <mpratt@google.com>

gopherbot · 2025-11-10T15:58:13Z

This PR is being closed because golang.org/cl/717760 has been merged.

austinderek mentioned this pull request Nov 4, 2025

sync: repanic when f() panics for WaitGroup.Go PullRequestInc/go#137

Closed

callthingsoff force-pushed the wggo branch from fa112c3 to 5bd20b8 Compare November 5, 2025 09:45

austinderek mentioned this pull request Nov 5, 2025

sync: repanic when f() panics for WaitGroup.Go PullRequestInc/go#146

Closed

callthingsoff force-pushed the wggo branch from 5bd20b8 to 24e36fb Compare November 5, 2025 19:23

callthingsoff force-pushed the wggo branch from 24e36fb to eedf805 Compare November 5, 2025 21:42

callthingsoff force-pushed the wggo branch from eedf805 to fb39447 Compare November 5, 2025 22:33

callthingsoff added 4 commits November 10, 2025 17:20

sync: repanic when f() panics for WaitGroup.Go

31e33b4

This is a copy-paste of golang#76126 (comment) by adonovan. Fixes golang#76126 Fixes golang#74702

2

ee2ad11

3

e3e78aa

4

b1beddc

callthingsoff force-pushed the wggo branch from 5d81a7e to b1beddc Compare November 10, 2025 09:22

anita5034 approved these changes Nov 10, 2025

View reviewed changes

gopherbot closed this Nov 10, 2025

callthingsoff deleted the wggo branch November 10, 2025 16:19

sync: don't call Done when f() panics in WaitGroup.Go #76172

sync: don't call Done when f() panics in WaitGroup.Go #76172

Conversation

callthingsoff commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Nov 4, 2025

Uh oh!

gopherbot commented Nov 4, 2025

Uh oh!

gopherbot commented Nov 4, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 7, 2025

Uh oh!

gopherbot commented Nov 7, 2025

Uh oh!

gopherbot commented Nov 7, 2025

Uh oh!

gopherbot commented Nov 7, 2025

Uh oh!

gopherbot commented Nov 7, 2025

Uh oh!

gopherbot commented Nov 7, 2025

Uh oh!

gopherbot commented Nov 7, 2025

Uh oh!

gopherbot commented Nov 7, 2025

Uh oh!

gopherbot commented Nov 7, 2025

Uh oh!

gopherbot commented Nov 7, 2025

Uh oh!

gopherbot commented Nov 8, 2025

Uh oh!

gopherbot commented Nov 10, 2025

Uh oh!

gopherbot commented Nov 10, 2025

Uh oh!

callthingsoff commented Nov 4, 2025 •

edited

Loading