-
Notifications
You must be signed in to change notification settings - Fork 0
testing nntp-transfer merge #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: testing-001
Are you sure you want to change the base?
Conversation
stuck in &nntp.CHTTJob .. requeue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a significant refactor for NNTP article transfer functionality, implementing a worker-based concurrent processing system to replace the previous sequential batch processing. The changes enable parallel CHECK/TAKETHIS operations across multiple workers while maintaining proper synchronization and error handling.
Key Changes
- Replaced sequential article processing with a multi-worker concurrent system using channels and goroutines
- Added proper job queuing, worker assignment, and response collection mechanisms
- Exported previously private fields in BackendConn struct for worker access
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/nntp-transfer/main.go | Complete rewrite of transfer logic to use worker pools and concurrent job processing |
| internal/nntp/nntp-client.go | Exported textConn and writer fields, added new types for job management |
| internal/nntp/nntp-client-commands.go | Added extensive worker management code and job processing structures |
| internal/nntp/nntp-backend-pool.go | Updated field reference to use exported Writer field |
| internal/nntp/nntp-article-common.go | Removed duplicate TakeThisMode type definition |
| internal/common/headers.go | Minor optimization to variable assignment order |
| internal/common/common.go | Added channel-based locking utilities |
Comments suppressed due to low confidence (1)
cmd/nntp-transfer/main.go:1
- Double unlock detected - the mutex is unlocked both in the defer statement and explicitly at line 210, which will cause a panic.
// NNTP article transfer tool for go-pugleaf
No description provided.