Fixed int.clamp and float.clamp in some case could be seen as misleading. #868
+26
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…could be seen as misleading.
NNBnh
changed the title
lpil
reviewed
Nov 1, 2025
Member
lpil
left a comment
lpil
left a comment
There was a problem hiding this comment.
Thank you! Would you mind rebasing on main and updating the changelog please 🙏
Sorry it took me so long to review this.
Author
|
Done! ^^ 
Edit: sorry forgot the changelog... |
Author
|
Okay, I added the changelog, my English is not the greatest but I hope it's good enough >< |
inoas
reviewed
Nov 9, 2025
| /// ``` | ||
| /// | ||
| /// ```gleam | ||
| /// clamp(1.2, min: 1.4, max: 0.6) |
Contributor
There was a problem hiding this comment.
maybe an inverse should be presented where min and max are turned around?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the issue #867, I have some suggested arguments naming:
The reason I choose
fn clamp(x, from start_bound, to stop_bound)is that it's more consistent with thelist.range(from start, to stop)arguments naming.