Skip to content

Conversation

@grodowski
Copy link
Contributor

Follow up to #1604, I noticed there's a bunch of currently unused fns. Please close this if these functions are used for ongoing development 🙇

Copilot AI review requested due to automatic review settings November 7, 2025 09:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request removes unused code from the binlog_file.go file, cleaning up dead code that is no longer referenced anywhere in the codebase.

  • Removes four unused methods: PreviousFileCoordinatesBy, PreviousFileCoordinates, NextFileCoordinates, and DetachedCoordinates
  • Removes the unused detachPattern regex variable and its initialization
  • Removes unused imports (errors and regexp) that were only needed by the deleted code

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant