JS: delete various outdated deprecations

Author: erik-krogh

javascript/ql/lib/semmle/javascript/ApiGraphs.qll

@@ -153,12 +153,6 @@ module API {
      */
     DataFlow::SourceNode asSource() { Impl::use(this, result) }
 
-    /** DEPRECATED. This predicate has been renamed to `asSource`. */
-    deprecated DataFlow::SourceNode getAnImmediateUse() { result = this.asSource() }
-
-    /** DEPRECATED. This predicate has been renamed to `getAValueReachableFromSource`. */
-    deprecated DataFlow::Node getAUse() { result = this.getAValueReachableFromSource() }
-
     /**
      * Gets a call to the function represented by this API component.
      */
@@ -212,12 +206,6 @@ module API {
      */
     DataFlow::Node getAValueReachingSink() { result = Impl::trackDefNode(this.asSink()) }
 
-    /** DEPRECATED. This predicate has been renamed to `asSink`. */
-    deprecated DataFlow::Node getARhs() { result = this.asSink() }
-
-    /** DEPRECATED. This predicate has been renamed to `getAValueReachingSink`. */
-    deprecated DataFlow::Node getAValueReachingRhs() { result = this.getAValueReachingSink() }
-
     /**
      * Gets a node representing member `m` of this API component.
      *
@@ -622,12 +610,6 @@ module API {
     bindingset[this]
     EntryPoint() { any() }
 
-    /** DEPRECATED. This predicate has been renamed to `getASource`. */
-    deprecated DataFlow::SourceNode getAUse() { none() }
-
-    /** DEPRECATED. This predicate has been renamed to `getASink`. */
-    deprecated DataFlow::SourceNode getARhs() { none() }
-
     /** Gets a data-flow node where a value enters the current codebase through this entry-point. */
     DataFlow::SourceNode getASource() { none() }
 

javascript/ql/lib/semmle/javascript/dataflow/DataFlow.qll

@@ -138,14 +138,6 @@ module DataFlow {
       CallGraph::getABoundFunctionReference(result, boundArgs, _).flowsTo(this)
     }
 
-    /**
-     * DEPRECATED: Use `DataFlow::ParameterNode::flowsTo()` instead.
-     * Holds if this expression may refer to the initial value of parameter `p`.
-     */
-    deprecated predicate mayReferToParameter(Parameter p) {
-      parameterNode(p).(SourceNode).flowsTo(this)
-    }
-
     /**
      * Holds if this element is at the specified location.
      * The location spans column `startcolumn` of line `startline` to

javascript/ql/lib/semmle/javascript/dataflow/Nodes.qll

@@ -1150,30 +1150,12 @@ module ClassNode {
     cached
     abstract FunctionNode getStaticMember(string name, MemberKind kind);
 
-    /**
-     * DEPRECATED. Override `getStaticMember` instead.
-     *
-     * Gets the static method of this class with the given name.
-     */
-    cached
-    deprecated FunctionNode getStaticMethod(string name) { none() }
-
     /**
      * Gets a static member of this class of the given kind.
      */
     cached
     abstract FunctionNode getAStaticMember(MemberKind kind);
 
-    /**
-     * DEPRECATED. Override `getAStaticMember` instead.
-     *
-     * Gets a static method of this class.
-     *
-     * The constructor is not considered a static method.
-     */
-    cached
-    deprecated FunctionNode getAStaticMethod() { none() }
-
     /**
      * Gets a dataflow node representing a class to be used as the super-class
      * of this node.

javascript/ql/lib/semmle/javascript/filters/ClassifyFiles.qll

@@ -75,9 +75,6 @@ predicate isExternsFile(File f) {
  */
 predicate isLibraryFile(File f) { f.getATopLevel() instanceof FrameworkLibraryInstance }
 
-/** DEPRECATED: Alias for isLibraryFile */
-deprecated predicate isLibaryFile = isLibraryFile/1;
-
 /**
  * Holds if `f` contains template code.
  */

javascript/ql/lib/semmle/javascript/frameworks/AngularJS/AngularJSCore.qll

@@ -618,27 +618,6 @@ private class JQLiteObject extends JQuery::ObjectSource::Range {
   }
 }
 
-/**
- * DEPRECATED: Use `AngularJSCallNode` instead.
- * A call to an AngularJS function.
- *
- * Used for exposing behavior that is similar to the behavior of other libraries.
- */
-deprecated class AngularJSCall extends CallExpr {
-  AngularJSCallNode node;
-
-  AngularJSCall() { this.flow() = node }
-
-  /** Holds if `e` is an argument that this call interprets as HTML. */
-  deprecated predicate interpretsArgumentAsHtml(Expr e) { node.interpretsArgumentAsHtml(e.flow()) }
-
-  /** Holds if `e` is an argument that this call stores globally, e.g. in a cookie. */
-  deprecated predicate storesArgumentGlobally(Expr e) { node.storesArgumentGlobally(e.flow()) }
-
-  /** Holds if `e` is an argument that this call interprets as code. */
-  deprecated predicate interpretsArgumentAsCode(Expr e) { node.interpretsArgumentAsCode(e.flow()) }
-}
-
 /**
  * A call to an AngularJS function.
  *

javascript/ql/lib/semmle/javascript/frameworks/AngularJS/ServiceDefinitions.qll

@@ -447,21 +447,6 @@ BuiltinServiceReference getBuiltinServiceOfKind(string kind) {
   )
 }
 
-/**
- * DEPRECATED: Use `ServiceRequestNode` instead.
- * A request for one or more AngularJS services.
- */
-deprecated class ServiceRequest extends Expr {
-  ServiceRequestNode node;
-
-  ServiceRequest() { this.flow() = node }
-
-  /** Gets the parameter of this request into which `service` is injected. */
-  deprecated Parameter getDependencyParameter(ServiceReference service) {
-    result.flow() = node.getDependencyParameter(service)
-  }
-}
-
 /**
  * A request for one or more AngularJS services.
  */

javascript/ql/lib/semmle/javascript/frameworks/Connect.qll

@@ -118,8 +118,6 @@ module Connect {
     override string getCredentialsKind() { result = kind }
   }
 
-  deprecated class RequestExpr = NodeJSLib::RequestExpr;
-
   class RequestNode = NodeJSLib::RequestNode;
 
   /**

javascript/ql/lib/semmle/javascript/frameworks/Credentials.qll

@@ -5,23 +5,6 @@
 
 import javascript
 
-/**
- * DEPRECATED: Use `CredentialsNode` instead.
- * An expression whose value is used to supply credentials such
- * as a user name, a password, or a key.
- */
-deprecated class CredentialsExpr extends Expr {
-  CredentialsNode node;
-
-  CredentialsExpr() { node.asExpr() = this }
-
-  /**
-   * Gets a description of the kind of credential this expression is used as,
-   * such as `"user name"`, `"password"`, `"key"`.
-   */
-  deprecated string getCredentialsKind() { result = node.getCredentialsKind() }
-}
-
 /**
  * An expression whose value is used to supply credentials such
  * as a user name, a password, or a key.

javascript/ql/lib/semmle/javascript/frameworks/Express.qll

@@ -55,14 +55,6 @@ module Express {
     WebpackDevServer::webpackDevServerApp().flowsTo(e)
   }
 
-  /**
-   * DEPRECATED: Use `RouterDefinition.ref()` or `RouteSetup` instead.
-   * An expression that refers to a route.
-   */
-  deprecated class RouteExpr extends MethodCallExpr {
-    RouteExpr() { isRouter(this.flow()) }
-  }
-
   /**
    * Gets the name of an Express router method that sets up a route.
    */
@@ -145,17 +137,6 @@ module Express {
     /** Holds if this is a call `use`, such as `app.use(handler)`. */
     predicate isUseCall() { this.getMethodName() = "use" }
 
-    /**
-     * DEPRECATED: Use `getRouteHandlerNode` instead.
-     * Gets the `n`th handler registered by this setup, with 0 being the first.
-     *
-     * This differs from `getARouteHandler` in that the argument expression is
-     * returned, not its dataflow source.
-     */
-    deprecated Expr getRouteHandlerExpr(int index) {
-      result = this.getRouteHandlerNode(index).asExpr()
-    }
-
     /**
      * Gets the `n`th handler registered by this setup, with 0 being the first.
      *
@@ -174,25 +155,11 @@ module Express {
       )
     }
 
-    /**
-     * DEPRECATED: Use `getARouteHandlerNode` instead.
-     * Gets an argument that represents a route handler being registered.
-     */
-    deprecated Expr getARouteHandlerExpr() { result = this.getRouteHandlerExpr(_) }
-
     /**
      * Gets an argument that represents a route handler being registered.
      */
     DataFlow::Node getARouteHandlerNode() { result = this.getRouteHandlerNode(_) }
 
-    /**
-     * DEPRECATED: Use `getLastRouteHandlerExpr` instead.
-     * Gets the last argument representing a route handler being registered.
-     */
-    deprecated Expr getLastRouteHandlerExpr() {
-      result = max(int i | | this.getRouteHandlerExpr(i) order by i)
-    }
-
     /**
      * Gets the last argument representing a route handler being registered.
      */
@@ -294,52 +261,6 @@ module Express {
     }
   }
 
-  /**
-   * DEPRECATED: Use `RouteHandlerNode` instead.
-   * An expression used as an Express route handler, such as `submitHandler` below:
-   * ```
-   * app.post('/submit', submitHandler)
-   * ```
-   *
-   * Unlike `RouterHandler`, this is the argument passed to a setup, as opposed to
-   * a function that flows into such an argument.
-   */
-  deprecated class RouteHandlerExpr extends Expr {
-    RouteHandlerNode node;
-
-    RouteHandlerExpr() { this.flow() = node }
-
-    /** Gets the setup call that registers this route handler. */
-    deprecated RouteSetup getSetup() { result = node.getSetup() }
-
-    /** Gets the function body of this handler, if it is defined locally. */
-    deprecated RouteHandler getBody() { result = node.getBody() }
-
-    /** Holds if this is not followed by more handlers. */
-    deprecated predicate isLastHandler() { node.isLastHandler() }
-
-    /** Gets a route handler that immediately precedes this in the route stack. */
-    deprecated Express::RouteHandlerExpr getPreviousMiddleware() {
-      result = node.getPreviousMiddleware().asExpr()
-    }
-
-    /** Gets a route handler that may follow immediately after this one in its route stack. */
-    deprecated Express::RouteHandlerExpr getNextMiddleware() {
-      result = node.getNextMiddleware().asExpr()
-    }
-
-    /**
-     * Gets a route handler that precedes this one (not necessarily immediately), may handle
-     * same request method, and matches on the same path or a prefix.
-     */
-    deprecated Express::RouteHandlerExpr getAMatchingAncestor() {
-      result = node.getAMatchingAncestor().asExpr()
-    }
-
-    /** Gets the router being registered as a sub-router here, if any. */
-    deprecated RouterDefinition getAsSubRouter() { result = node.getAsSubRouter() }
-  }
-
   /**
    * An expression used as an Express route handler, such as `submitHandler` below:
    * ```
@@ -584,29 +505,13 @@ module Express {
     override RouteHandler getRouteHandler() { none() } // Not known.
   }
 
-  /**
-   * DEPRECATED: Use `ResponseNode` instead.
-   * An Express response expression.
-   */
-  deprecated class ResponseExpr extends NodeJSLib::ResponseExpr {
-    ResponseExpr() { this.flow() instanceof ResponseNode }
-  }
-
   /**
    * An Express response expression.
    */
   class ResponseNode extends NodeJSLib::ResponseNode {
     override ResponseSource src;
   }
 
-  /**
-   * DEPRECATED: Use `RequestNode` instead.
-   * An Express request expression.
-   */
-  deprecated class RequestExpr extends NodeJSLib::RequestExpr {
-    RequestExpr() { this.flow() instanceof RequestNode }
-  }
-
   /**
    * An Express request expression.
    */

javascript/ql/lib/semmle/javascript/frameworks/Fastify.qll

@@ -154,12 +154,6 @@ module Fastify {
 
     override DataFlow::SourceNode getServer() { result = server }
 
-    /**
-     * DEPRECATED: Use `getARouteHandlerNode` instead.
-     * Gets an argument that represents a route handler being registered.
-     */
-    deprecated DataFlow::Node getARouteHandlerExpr() { result = this.getARouteHandlerNode() }
-
     /**  Gets an argument that represents a route handler being registered. */
     DataFlow::Node getARouteHandlerNode() {
       if methodName = "route"