Ruby: delete various deprecated predicates

Author: erik-krogh

ruby/ql/lib/codeql/ruby/Concepts.qll

@@ -1096,10 +1096,7 @@ module Cryptography {
    * extend `CryptographicOperation::Range` instead.
    */
   class CryptographicOperation extends SC::CryptographicOperation instanceof CryptographicOperation::Range
-  {
-    /** DEPRECATED: Use `getAlgorithm().isWeak() or getBlockMode().isWeak()` instead */
-    deprecated predicate isWeak() { super.isWeak() }
-  }
+  { }
 
   /** Provides classes for modeling new applications of a cryptographic algorithms. */
   module CryptographicOperation {
@@ -1110,10 +1107,7 @@ module Cryptography {
      * Extend this class to model new APIs. If you want to refine existing API models,
      * extend `CryptographicOperation` instead.
      */
-    abstract class Range extends SC::CryptographicOperation::Range {
-      /** DEPRECATED: Use `getAlgorithm().isWeak() or getBlockMode().isWeak()` instead */
-      deprecated predicate isWeak() { this.getAlgorithm().isWeak() or this.getBlockMode().isWeak() }
-    }
+    abstract class Range extends SC::CryptographicOperation::Range { }
   }
 
   class BlockMode = SC::BlockMode;

ruby/ql/lib/codeql/ruby/ast/Constant.qll

@@ -80,12 +80,6 @@ class ConstantValue extends TConstantValue {
   /** Holds if this is the regexp value `/s/flags` . */
   predicate isRegExpWithFlags(string s, string flags) { this = TRegExp(s, flags) }
 
-  /** DEPRECATED: Use `getStringlikeValue` instead. */
-  deprecated string getStringOrSymbol() { result = this.getStringlikeValue() }
-
-  /** DEPRECATED: Use `isStringlikeValue` instead. */
-  deprecated predicate isStringOrSymbol(string s) { s = this.getStringlikeValue() }
-
   /** Gets the string/symbol/regexp value, if any. */
   string getStringlikeValue() { result = [this.getString(), this.getSymbol(), this.getRegExp()] }
 

ruby/ql/lib/codeql/ruby/frameworks/core/internal/IOOrFile.qll

@@ -63,9 +63,6 @@ abstract class IOOrFileMethodCall extends DataFlow::CallNode {
   /** Gets the API used to perform this call, either "IO" or "File" */
   abstract string getApi();
 
-  /** DEPRECATED: Alias for getApi */
-  deprecated string getAPI() { result = this.getApi() }
-
   /** Gets a node representing the data read or written by this call */
   abstract DataFlow::Node getADataNodeImpl();
 
@@ -115,9 +112,6 @@ class IOOrFileReadMethodCall extends IOOrFileMethodCall {
 
   override string getApi() { result = api }
 
-  /** DEPRECATED: Alias for getApi */
-  deprecated override string getAPI() { result = this.getApi() }
-
   override DataFlow::Node getADataNodeImpl() { result = this }
 
   override string getReceiverKind() { result = receiverKind }
@@ -159,9 +153,6 @@ class IOOrFileWriteMethodCall extends IOOrFileMethodCall {
 
   override string getApi() { result = api }
 
-  /** DEPRECATED: Alias for getApi */
-  deprecated override string getAPI() { result = this.getApi() }
-
   override DataFlow::Node getADataNodeImpl() { result = dataNode }
 
   override string getReceiverKind() { result = receiverKind }