Merge pull request #10867 from hvitved/ruby/orm-tracking-redundant-additional-step

hvitved · web-flow · commit 19bcd287cb76 · 2022-10-18T10:03:51.000+02:00
Ruby: Remove redundant additional flow step from `OrmTracking::Configuration`
diff --git a/ruby/ql/lib/codeql/ruby/security/XSS.qll b/ruby/ql/lib/codeql/ruby/security/XSS.qll
@@ -350,9 +350,6 @@ private module OrmTracking {
       or
       // Propagate flow through arbitrary method calls
       node2.(DataFlow2::CallNode).getReceiver() = node1
-      or
-      // Propagate flow through "or" expressions `or`/`||`
-      node2.asExpr().getExpr().(LogicalOrExpr).getAnOperand() = node1.asExpr().getExpr()
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -350,9 +350,6 @@ private module OrmTracking {`
`350`	`350`	`or`
`351`	`351`	`// Propagate flow through arbitrary method calls`
`352`	`352`	`node2.(DataFlow2::CallNode).getReceiver() = node1`
`353`		`- or`
`354`		- // Propagate flow through "or" expressions `or`/`\|\|`
`355`		`- node2.asExpr().getExpr().(LogicalOrExpr).getAnOperand() = node1.asExpr().getExpr()`
`356`	`353`	`}`
`357`	`354`	`}`
`358`	`355`	`}`