Ruby: Remove redundant additional flow step from OrmTracking::Configuration

hvitved · hvitved · commit 1266d248ed28 · 2022-10-18T09:33:29.000+02:00
diff --git a/ruby/ql/lib/codeql/ruby/security/XSS.qll b/ruby/ql/lib/codeql/ruby/security/XSS.qll
@@ -339,9 +339,6 @@ private module OrmTracking {
       or
       // Propagate flow through arbitrary method calls
       node2.(DataFlow2::CallNode).getReceiver() = node1
-      or
-      // Propagate flow through "or" expressions `or`/`||`
-      node2.asExpr().getExpr().(LogicalOrExpr).getAnOperand() = node1.asExpr().getExpr()
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -339,9 +339,6 @@ private module OrmTracking {`
`339`	`339`	`or`
`340`	`340`	`// Propagate flow through arbitrary method calls`
`341`	`341`	`node2.(DataFlow2::CallNode).getReceiver() = node1`
`342`		`- or`
`343`		- // Propagate flow through "or" expressions `or`/`\|\|`
`344`		`- node2.asExpr().getExpr().(LogicalOrExpr).getAnOperand() = node1.asExpr().getExpr()`
`345`	`342`	`}`
`346`	`343`	`}`
`347`	`344`	`}`