Skip to content

Fix CI #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix CI #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pyright.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v6
with:
python-version: '3.x'
python-version: '3.12'
Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The pytest workflow uses a matrix strategy to test against Python versions 3.9, 3.10, 3.11, 3.12, and 3.13, while the project supports Python >=3.6 (per pyproject.toml). Pinning pyright to only Python 3.12 means type checking won't catch type issues specific to other supported versions. Consider testing type checking against the minimum supported version (3.6 or 3.9) to ensure backward compatibility, or against multiple versions if version-specific type behaviors are a concern.

See below for a potential fix:

    strategy:
      matrix:
        python-version: [3.6, 3.9, 3.10, 3.11, 3.12, 3.13]
    steps:
    - uses: actions/checkout@v5
    - name: Set up Python
      uses: actions/setup-python@v6
      with:
        python-version: ${{ matrix.python-version }}

Copilot uses AI. Check for mistakes.
- name: Install dependencies
run: |
python -m pip install hatch
Expand Down
Loading