Skip to content

Commit bbc04b0

Browse files
jacob-kellergitster
authored andcommitted
t9001-send-email.sh: update alias list used for pine test
The set of aliases used for the pine --dump-aliases test do not perfectly mesh with the way the pine address book is defined. While technically all valid, there are some oddities including bob's name being partially split so that the actual address is returned as "Bobbyton <bob@example.com>". A strict reading of the pine documentation indicates that the address should either be of the form "address@domain" or a comma separated list of address, name/address pairs, or other aliases enclosed by (). The parsing implementation in git-send-email is not as strict, but it makes sense to ensure the test data used is. Although the --dump-aliases test does not make use of the address data, it is helpful to avoid giving future developers the wrong impression of the file format. Also add an alias which translates to multiple addresses using the () format. Signed-off-by: Jacob Keller <jacob.keller@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 16d89aa commit bbc04b0

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

t/t9001-send-email.sh

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2093,13 +2093,15 @@ test_dump_aliases '--dump-aliases mailrc format' \
20932093
test_dump_aliases '--dump-aliases pine format' \
20942094
'pine' \
20952095
'alice' \
2096+
'bcgrp' \
20962097
'bob' \
20972098
'chloe' \
20982099
'eve' <<-\EOF
2099-
alice Alice W Land <awol@example.com>
2100-
eve Eve <eve@example.com>
2101-
bob Robert Bobbyton <bob@example.com>
2100+
alice Alice W Land awol@example.com Friend
2101+
eve Eve eve@example.com
2102+
bob Robert Bobbyton bob@example.com
21022103
chloe chloe@example.com
2104+
bcgrp (bob, chloe, Other <o@example.com>)
21032105
EOF
21042106

21052107
test_dump_aliases '--dump-aliases gnus format' \

0 commit comments

Comments
 (0)