Skip to content

Commit 16d89aa

Browse files
jacob-kellergitster
authored andcommitted
t9001-send-email.sh: fix quoting for mailrc --dump-aliases test
The .mailrc alias file format documents that multiple addresses are separated by spaces. The alias file used in the t9001 --dump-aliases mailrc test have addresses which include both a name and email. These are unquoted, so git send-email will parse this as an alias that translates to multiple independent addresses. The existing test does not care about this, as --dump-aliases only dumps the alias and not the address. However, it is incorrect for a future where --dump-aliases could also dump the mail addresses. Fix the test to quote the aliases properly, so that they translate to a single address. Signed-off-by: Jacob Keller <jacob.keller@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 25673b1 commit 16d89aa

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

t/t9001-send-email.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2084,9 +2084,9 @@ test_dump_aliases '--dump-aliases mailrc format' \
20842084
'bob' \
20852085
'chloe' \
20862086
'eve' <<-\EOF
2087-
alias alice Alice W Land <awol@example.com>
2088-
alias eve Eve <eve@example.com>
2089-
alias bob Robert Bobbyton <bob@example.com>
2087+
alias alice "Alice W Land <awol@example.com>"
2088+
alias eve "Eve <eve@example.com>"
2089+
alias bob "Robert Bobbyton <bob@example.com>"
20902090
alias chloe chloe@example.com
20912091
EOF
20922092

0 commit comments

Comments
 (0)