ProjectOptions: do not allow the config to be passed implicitly

Implicit configuration is a recipe for confusion when trying to allow
for overriding said configuration. Let's require the config to be passed
down explicitly.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Author: dscho

lib/patch-series.ts

@@ -140,7 +140,7 @@ export class PatchSeries {
 
         const publishToRemote: string | undefined = undefined;
 
-        const project = await ProjectOptions.get(workDir, headCommit, cc, basedOn, publishToRemote, baseCommit);
+        const project = await ProjectOptions.get(config, workDir, headCommit, cc, basedOn, publishToRemote, baseCommit);
         if (rangeDiff) {
             options.rangeDiff = rangeDiff;
         }

lib/project-options.ts

@@ -1,17 +1,17 @@
 import { commitExists, git, revParse } from "./git.js";
-import { IConfig, getConfig, projectInfo } from "./project-config.js";
+import { IConfig, projectInfo } from "./project-config.js";
 
 // For now, only the Git, Cygwin and BusyBox projects are supported
 export class ProjectOptions {
     public static async get(
+        config: IConfig,
         workDir: string,
         branchName: string,
         cc: string[],
         basedOn?: string,
         publishToRemote?: string,
         baseCommit?: string,
     ): Promise<ProjectOptions> {
-        const config: IConfig = getConfig();
         let upstreamBranch: string;
         let to: string;
         let midUrlPrefix = " Message-ID: ";

tests/project-options.test.ts

@@ -27,6 +27,7 @@ test("project options", async () => {
     expect(await repo.commit("C")).not.toEqual("");
 
     const options2 = await ProjectOptions.get(
+        defaultConfig,
         repo.workDir,
         "test-project-options",
         ["Nguyễn Thái Ngọc Duy <pclouds@gmail.com>"],